Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Tales of Xillia crashes right before the game loads from the 2/26 update and on #15361

Closed
Daniel-Katz opened this issue Mar 26, 2024 · 1 comment · Fixed by #15363

Comments

@Daniel-Katz
Copy link

Quick summary

New versions of RPCS3 cause Tales of Xillia to crash

Details

I don't know what the issue with the 2/26 update is, but from that version and on (double checked a couple of versions including the latest one as of this moment) Tales of Xillia causes RPCS3 to crash before the game "starts". The pre-game loading bars all do their thing, a black screen shows for a few seconds and then instead of Tales of Xillia starting, RPCS3 just closes. No error message or anything, just closes.

When I reverted to the 2/24 update the game resumed working normally.

For the record, no, I'm not talking about how the game freezes if you try to skip past all the pre-credits. THAT happens even with the working versions.

Build with regression

0.0.30-16146

Attach two log files

I made copies of the 2 versions of the log, named the one that was a log for the 2/24 version that worked "RPCS3 - Good" and the one that was a log for the 2/26 version that crashed "RPCS3 - Bad"

RPCS3.-.Good.log
RPCS3.-.Bad.log

Attach capture files for visual issues

No response

System configuration

No response

Other details

No response

@Megamouse
Copy link
Contributor

Megamouse commented Mar 27, 2024

@kd-11 I've briefly looked into this and it turns out that image_to_flip2 is nullptr in GLGSRender::flip, which either way leads to a simple_array of size 2 and then images.map(FN...). It then tries to call xform with the dereferenced nullptr in simple_array::map.

So there's 3 potential bugs here:

  1. deref nullptr in map
  2. using a simple_array of size 2 even though image_to_flip2 is nullptr
  3. having a nullptr in image_to_flip2 in the first place

And probably the simple solution being to push a default initialized object if "it" is nullptr, since the run function checks for GL_NONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants