Remove gfx940 / gfx941 code #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umfranzw
requested review from
stanleytsang-amd,
RobsonRLemos and
lawruble13
as code owners
|
Strange this target only removal was to be done for 6.3. I would look at what else was not cascaded to 6.4 staging and develop |
umfranzw
changed the base branch from
develop
to
release-staging/rocm-rel-6.4
amd-jnovotny
approved these changes
Feb 11, 2025
CHANGELOG.md
Outdated
Comment on lines
8
to
12
| ### Changed | ||
| * Updated several `gfx942` auto tuning parameters. | ||
|
|
||
| ### Fixed | ||
| * Fixed an issue where `mt19937.hpp` would cause kernel errors during auto tuning. |
There was a problem hiding this comment.
Suggested change
| ### Changed | |
| * Updated several `gfx942` auto tuning parameters. | |
| ### Fixed | |
| * Fixed an issue where `mt19937.hpp` would cause kernel errors during auto tuning. | |
| ### Changed | |
| * Updated several `gfx942` auto-tuning parameters. | |
| ### Fixed | |
| * Fixed an issue where `mt19937.hpp` would cause kernel errors during auto-tuning. |
There was a problem hiding this comment.
Thanks @amd-jnovotny. I temporarily messed up the commit history on this PR when I switched target branches. The problem's resolved now, and the PR no longer touches the changelog.
Moving forward we will no longer support custom builds for gfx940 and gfx941. This change removes code that references those architectures.
umfranzw
force-pushed
the
remove_gfx94x
branch
from
88ded23 to
3bd8768
Compare
stanleytsang-amd
approved these changes
Feb 11, 2025
umfranzw
merged commit e75f86b
into
ROCm:release-staging/rocm-rel-6.4
10 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving forward we will no longer support custom builds for gfx940 and gfx941. This change removes code that references those architectures.