Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gfx940 / gfx941 code #609

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

umfranzw
Copy link
Collaborator

@umfranzw umfranzw commented Feb 7, 2025

Moving forward we will no longer support custom builds for gfx940 and gfx941. This change removes code that references those architectures.

@TorreZuk
Copy link
Contributor

Strange this target only removal was to be done for 6.3. I would look at what else was not cascaded to 6.4 staging and develop

@stanleytsang-amd
Copy link
Collaborator

@TorreZuk You're right - it was done for 6.3, but somehow the mergeback PR to develop was incomplete and did not remove the targets entirely.
@umfranzw Can you target the 6.4 release-staging branch with this PR instead? We'll then merge it back to develop (correctly) afterwards.

@umfranzw umfranzw changed the base branch from develop to release-staging/rocm-rel-6.4 February 11, 2025 21:19
@umfranzw umfranzw requested a review from a team as a code owner February 11, 2025 21:19
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs and changelog changes okay. One minor hyphenation suggestion.

CHANGELOG.md Outdated
Comment on lines 8 to 12
### Changed
* Updated several `gfx942` auto tuning parameters.

### Fixed
* Fixed an issue where `mt19937.hpp` would cause kernel errors during auto tuning.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Changed
* Updated several `gfx942` auto tuning parameters.
### Fixed
* Fixed an issue where `mt19937.hpp` would cause kernel errors during auto tuning.
### Changed
* Updated several `gfx942` auto-tuning parameters.
### Fixed
* Fixed an issue where `mt19937.hpp` would cause kernel errors during auto-tuning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amd-jnovotny. I temporarily messed up the commit history on this PR when I switched target branches. The problem's resolved now, and the PR no longer touches the changelog.

Moving forward we will no longer support custom
builds for gfx940 and gfx941. This change removes
code that references those architectures.
@umfranzw umfranzw merged commit e75f86b into ROCm:release-staging/rocm-rel-6.4 Feb 11, 2025
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants