-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gfx940 / gfx941 code #609
Remove gfx940 / gfx941 code #609
Conversation
Strange this target only removal was to be done for 6.3. I would look at what else was not cascaded to 6.4 staging and develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs and changelog changes okay. One minor hyphenation suggestion.
CHANGELOG.md
Outdated
### Changed | ||
* Updated several `gfx942` auto tuning parameters. | ||
|
||
### Fixed | ||
* Fixed an issue where `mt19937.hpp` would cause kernel errors during auto tuning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Changed | |
* Updated several `gfx942` auto tuning parameters. | |
### Fixed | |
* Fixed an issue where `mt19937.hpp` would cause kernel errors during auto tuning. | |
### Changed | |
* Updated several `gfx942` auto-tuning parameters. | |
### Fixed | |
* Fixed an issue where `mt19937.hpp` would cause kernel errors during auto-tuning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amd-jnovotny. I temporarily messed up the commit history on this PR when I switched target branches. The problem's resolved now, and the PR no longer touches the changelog.
Moving forward we will no longer support custom builds for gfx940 and gfx941. This change removes code that references those architectures.
88ded23
to
3bd8768
Compare
e75f86b
into
ROCm:release-staging/rocm-rel-6.4
Moving forward we will no longer support custom builds for gfx940 and gfx941. This change removes code that references those architectures.