Skip to content

Commit b21feff

Browse files
committed
[Comgr][v3.0] Remove unused action and language
- AMD_COMGR_ACTION_OPTIMIZE_BC_TO_BC - AMD_COMGR_LANGUAGE_HC Change-Id: Ie82b51bb8a1b0fc438ec3b4eb3965341710a56da
1 parent fc4d513 commit b21feff

File tree

3 files changed

+18
-33
lines changed

3 files changed

+18
-33
lines changed

amd/comgr/docs/ReleaseNotes.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,10 @@ Removed Comgr Actions and Data Types
166166
- (Action) AMD\_COMGR\_ACTION\_COMPILE\_SOURCE\_TO\_FATBIN
167167
- This workaround has been removed in favor of
168168
\*\_COMPILE\_SOURCE\_(WITH\_DEVICE\_LIBS\_)TO\_BC
169+
- (Action) AMD\_COMGR\_ACTION\_OPTIMIZE\_BC\_TO\_BC
170+
- This is a legacy action that was never implemented
171+
- (Language) AMD\_COMGR\_LANGUAGE\_HC
172+
- This is a legacy language that was never used
169173

170174
Comgr Testing, Debugging, and Logging Updates
171175
---------------------------------------------

amd/comgr/include/amd_comgr.h.in

Lines changed: 14 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -277,18 +277,14 @@ typedef enum amd_comgr_language_s {
277277
* OpenCL 2.0.
278278
*/
279279
AMD_COMGR_LANGUAGE_OPENCL_2_0 = 0x2,
280-
/**
281-
* AMD Hetrogeneous C++ (HC).
282-
*/
283-
AMD_COMGR_LANGUAGE_HC = 0x3,
284280
/**
285281
* HIP.
286282
*/
287-
AMD_COMGR_LANGUAGE_HIP = 0x4,
283+
AMD_COMGR_LANGUAGE_HIP = 0x3,
288284
/**
289285
* LLVM IR, either textual (.ll) or bitcode (.bc) format.
290286
*/
291-
AMD_COMGR_LANGUAGE_LLVM_IR = 0x5,
287+
AMD_COMGR_LANGUAGE_LLVM_IR = 0x4,
292288
/**
293289
* Marker for last valid language.
294290
*/
@@ -1644,17 +1640,6 @@ typedef enum amd_comgr_action_kind_s {
16441640
* any DataObject in the input set.
16451641
*/
16461642
AMD_COMGR_ACTION_LINK_BC_TO_BC = 0x4,
1647-
/**
1648-
* Optimize each bc data object in @p input and create an optimized bc data
1649-
* object to @p result.
1650-
*
1651-
* Return @p AMD_COMGR_STATUS_ERROR if the optimization fails.
1652-
*
1653-
* Return @p AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT
1654-
* if isa name is not set in @p info and does not match the isa name
1655-
* of all bc data objects in @p input.
1656-
*/
1657-
AMD_COMGR_ACTION_OPTIMIZE_BC_TO_BC = 0x5,
16581643
/**
16591644
* Perform code generation for each bc data object in @p input in
16601645
* order. For each successful code generation add a relocatable data
@@ -1667,7 +1652,7 @@ typedef enum amd_comgr_action_kind_s {
16671652
* if isa name is not set in @p info and does not match the isa name
16681653
* of all bc data objects in @p input.
16691654
*/
1670-
AMD_COMGR_ACTION_CODEGEN_BC_TO_RELOCATABLE = 0x6,
1655+
AMD_COMGR_ACTION_CODEGEN_BC_TO_RELOCATABLE = 0x5,
16711656
/**
16721657
* Perform code generation for each bc data object in @p input in
16731658
* order. For each successful code generation add an assembly source data
@@ -1680,7 +1665,7 @@ typedef enum amd_comgr_action_kind_s {
16801665
* if isa name is not set in @p info and does not match the isa name
16811666
* of all bc data objects in @p input.
16821667
*/
1683-
AMD_COMGR_ACTION_CODEGEN_BC_TO_ASSEMBLY = 0x7,
1668+
AMD_COMGR_ACTION_CODEGEN_BC_TO_ASSEMBLY = 0x6,
16841669
/**
16851670
* Link each relocatable data object in @p input together and add
16861671
* the linked relocatable data object to @p result. Any device
@@ -1693,7 +1678,7 @@ typedef enum amd_comgr_action_kind_s {
16931678
* if isa name is not set in @p info and does not match the isa name
16941679
* of all relocatable data objects in @p input.
16951680
*/
1696-
AMD_COMGR_ACTION_LINK_RELOCATABLE_TO_RELOCATABLE = 0x8,
1681+
AMD_COMGR_ACTION_LINK_RELOCATABLE_TO_RELOCATABLE = 0x7,
16971682
/**
16981683
* Link each relocatable data object in @p input together and add
16991684
* the linked executable data object to @p result. Any device
@@ -1706,7 +1691,7 @@ typedef enum amd_comgr_action_kind_s {
17061691
* if isa name is not set in @p info and does not match the isa name
17071692
* of all relocatable data objects in @p input.
17081693
*/
1709-
AMD_COMGR_ACTION_LINK_RELOCATABLE_TO_EXECUTABLE = 0x9,
1694+
AMD_COMGR_ACTION_LINK_RELOCATABLE_TO_EXECUTABLE = 0x8,
17101695
/**
17111696
* Assemble each source data object in @p input in order into machine code.
17121697
* For each successful assembly add a relocatable data object to @p result.
@@ -1719,7 +1704,7 @@ typedef enum amd_comgr_action_kind_s {
17191704
* Return @p AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT if isa name is not set in
17201705
* @p info.
17211706
*/
1722-
AMD_COMGR_ACTION_ASSEMBLE_SOURCE_TO_RELOCATABLE = 0xA,
1707+
AMD_COMGR_ACTION_ASSEMBLE_SOURCE_TO_RELOCATABLE = 0x9,
17231708
/**
17241709
* Disassemble each relocatable data object in @p input in
17251710
* order. For each successful disassembly add a source data object to
@@ -1732,7 +1717,7 @@ typedef enum amd_comgr_action_kind_s {
17321717
* if isa name is not set in @p info and does not match the isa name
17331718
* of all relocatable data objects in @p input.
17341719
*/
1735-
AMD_COMGR_ACTION_DISASSEMBLE_RELOCATABLE_TO_SOURCE = 0xB,
1720+
AMD_COMGR_ACTION_DISASSEMBLE_RELOCATABLE_TO_SOURCE = 0xA,
17361721
/**
17371722
* Disassemble each executable data object in @p input in order. For
17381723
* each successful disassembly add a source data object to @p result.
@@ -1744,7 +1729,7 @@ typedef enum amd_comgr_action_kind_s {
17441729
* if isa name is not set in @p info and does not match the isa name
17451730
* of all relocatable data objects in @p input.
17461731
*/
1747-
AMD_COMGR_ACTION_DISASSEMBLE_EXECUTABLE_TO_SOURCE = 0xC,
1732+
AMD_COMGR_ACTION_DISASSEMBLE_EXECUTABLE_TO_SOURCE = 0xB,
17481733
/**
17491734
* Disassemble each bytes data object in @p input in order. For each
17501735
* successful disassembly add a source data object to @p
@@ -1759,7 +1744,7 @@ typedef enum amd_comgr_action_kind_s {
17591744
* Return @p AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT
17601745
* if isa name is not set in @p info
17611746
*/
1762-
AMD_COMGR_ACTION_DISASSEMBLE_BYTES_TO_SOURCE = 0xD,
1747+
AMD_COMGR_ACTION_DISASSEMBLE_BYTES_TO_SOURCE = 0xC,
17631748
/**
17641749
* Compile each source data object in @p input in order. For each
17651750
* successful compilation add a bc data object to @p result. Resolve
@@ -1776,7 +1761,7 @@ typedef enum amd_comgr_action_kind_s {
17761761
* Return @p AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT
17771762
* if isa name or language is not set in @p info.
17781763
*/
1779-
AMD_COMGR_ACTION_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC = 0xE,
1764+
AMD_COMGR_ACTION_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC = 0xD,
17801765
/**
17811766
* Compile a single source data object in @p input in order. For each
17821767
* successful compilation add a relocatable data object to @p result.
@@ -1793,7 +1778,7 @@ typedef enum amd_comgr_action_kind_s {
17931778
* Return @p AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT
17941779
* if isa name or language is not set in @p info.
17951780
*/
1796-
AMD_COMGR_ACTION_COMPILE_SOURCE_TO_RELOCATABLE = 0xF,
1781+
AMD_COMGR_ACTION_COMPILE_SOURCE_TO_RELOCATABLE = 0xE,
17971782
/**
17981783
* Compile each source data object in @p input and create a single executabele
17991784
* in @p result. Resolve any include source names using the names of include
@@ -1809,7 +1794,7 @@ typedef enum amd_comgr_action_kind_s {
18091794
* Return @p AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT
18101795
* if isa name or language is not set in @p info.
18111796
*/
1812-
AMD_COMGR_ACTION_COMPILE_SOURCE_TO_EXECUTABLE = 0x10,
1797+
AMD_COMGR_ACTION_COMPILE_SOURCE_TO_EXECUTABLE = 0xF,
18131798

18141799
/**
18151800
* Unbundle each source data object in @p input. These objects can be
@@ -1823,7 +1808,7 @@ typedef enum amd_comgr_action_kind_s {
18231808
* Return @p AMD_COMGR_STATUS_ERROR_INVALID_ARGUMENT
18241809
* if isa name or language is not set in @p info.
18251810
*/
1826-
AMD_COMGR_ACTION_UNBUNDLE = 0x11,
1811+
AMD_COMGR_ACTION_UNBUNDLE = 0x10,
18271812

18281813
/**
18291814
* Marker for last valid action kind.

amd/comgr/src/comgr.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,6 @@ StringRef getActionKindName(amd_comgr_action_kind_t ActionKind) {
221221
return "AMD_COMGR_ACTION_ADD_DEVICE_LIBRARIES";
222222
case AMD_COMGR_ACTION_LINK_BC_TO_BC:
223223
return "AMD_COMGR_ACTION_LINK_BC_TO_BC";
224-
case AMD_COMGR_ACTION_OPTIMIZE_BC_TO_BC:
225-
return "AMD_COMGR_ACTION_OPTIMIZE_BC_TO_BC";
226224
case AMD_COMGR_ACTION_CODEGEN_BC_TO_RELOCATABLE:
227225
return "AMD_COMGR_ACTION_CODEGEN_BC_TO_RELOCATABLE";
228226
case AMD_COMGR_ACTION_CODEGEN_BC_TO_ASSEMBLY:
@@ -260,8 +258,6 @@ static StringRef getLanguageName(amd_comgr_language_t Language) {
260258
return "AMD_COMGR_LANGUAGE_OPENCL_1_2";
261259
case AMD_COMGR_LANGUAGE_OPENCL_2_0:
262260
return "AMD_COMGR_LANGUAGE_OPENCL_2_0";
263-
case AMD_COMGR_LANGUAGE_HC:
264-
return "AMD_COMGR_LANGUAGE_HC";
265261
case AMD_COMGR_LANGUAGE_HIP:
266262
return "AMD_COMGR_LANGUAGE_HIP";
267263
case AMD_COMGR_LANGUAGE_LLVM_IR:

0 commit comments

Comments
 (0)