Skip to content

Commit 076ae87

Browse files
authored
Fix failing LLVM and MLIR LIT tests (#22)
PR #21 resulted in these broken tests due to changes in the produced IR. This patch updates the tests to expect the new IR.
1 parent 95d748c commit 076ae87

File tree

3 files changed

+7
-20
lines changed

3 files changed

+7
-20
lines changed

llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5971,14 +5971,8 @@ TEST_F(OpenMPIRBuilderTest, TargetRegionDevice) {
59715971
EXPECT_TRUE(isa<AllocaInst>(Alloca2));
59725972
auto *Store2 = Alloca2->getNextNode();
59735973
EXPECT_TRUE(isa<StoreInst>(Store2));
5974-
auto *Alloca3 = Store2->getNextNode();
5975-
EXPECT_TRUE(isa<AllocaInst>(Alloca3));
5976-
auto *Store3 = Alloca3->getNextNode();
5977-
EXPECT_TRUE(isa<StoreInst>(Store3));
5978-
auto *Load1 = Store3->getNextNode();
5979-
EXPECT_TRUE(isa<LoadInst>(Load1));
59805974

5981-
auto *InitCall = dyn_cast<CallInst>(Load1->getNextNode());
5975+
auto *InitCall = dyn_cast<CallInst>(Store2->getNextNode());
59825976
EXPECT_NE(InitCall, nullptr);
59835977
EXPECT_EQ(InitCall->getCalledFunction()->getName(), "__kmpc_target_init");
59845978
EXPECT_EQ(InitCall->arg_size(), 2U);
@@ -6002,12 +5996,12 @@ TEST_F(OpenMPIRBuilderTest, TargetRegionDevice) {
60025996
// Check user code block
60035997
auto *UserCodeBlock = EntryBlockBranch->getSuccessor(0);
60045998
EXPECT_EQ(UserCodeBlock->getName(), "user_code.entry");
6005-
auto *Load2 = UserCodeBlock->getFirstNonPHI();
5999+
auto *Load1 = UserCodeBlock->getFirstNonPHI();
6000+
EXPECT_TRUE(isa<LoadInst>(Load1));
6001+
auto *Load2 = Load1->getNextNode();
60066002
EXPECT_TRUE(isa<LoadInst>(Load2));
6007-
auto *Load3 = Load2->getNextNode();
6008-
EXPECT_TRUE(isa<LoadInst>(Load3));
60096003

6010-
auto *Value1 = Load3->getNextNode();
6004+
auto *Value1 = Load2->getNextNode();
60116005
EXPECT_EQ(Value1, Value);
60126006
EXPECT_EQ(Value1->getNextNode(), TargetStore);
60136007
auto *Deinit = TargetStore->getNextNode();

mlir/test/Target/LLVMIR/omptarget-parallel-llvm.mlir

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,7 @@ module attributes {dlti.dl_spec = #dlti.dl_spec<#dlti.dl_entry<"dlti.alloca_memo
6363
// CHECK: %[[TMP3:.*]] = alloca ptr, align 8, addrspace(5)
6464
// CHECK: %[[TMP4:.*]] = addrspacecast ptr addrspace(5) %[[TMP3]] to ptr
6565
// CHECK: store ptr %[[TMP0]], ptr %[[TMP4]], align 8
66-
// CHECK: %[[KERNEL_LAUNCH_ENV_TMP:.*]] = alloca ptr, align 8, addrspace(5)
67-
// CHECK: %[[KERNEL_LAUNCH_ENV_TMP_CAST:.*]] = addrspacecast ptr addrspace(5) %[[KERNEL_LAUNCH_ENV_TMP]] to ptr
68-
// CHECK: store ptr %[[TMP]], ptr %[[KERNEL_LAUNCH_ENV_TMP_CAST]], align 8
69-
// CHECK: %[[KERNEL_LAUNCH_ENV:.*]] = load ptr, ptr %[[KERNEL_LAUNCH_ENV_TMP_CAST]], align 8
70-
// CHECK: %[[TMP5:.*]] = call i32 @__kmpc_target_init(ptr addrspacecast (ptr addrspace(1) @{{.*}} to ptr), ptr %[[KERNEL_LAUNCH_ENV]])
66+
// CHECK: %[[TMP5:.*]] = call i32 @__kmpc_target_init(ptr addrspacecast (ptr addrspace(1) @{{.*}} to ptr), ptr %[[TMP]])
7167
// CHECK: %[[EXEC_USER_CODE:.*]] = icmp eq i32 %[[TMP5]], -1
7268
// CHECK: br i1 %[[EXEC_USER_CODE]], label %[[USER_CODE_ENTRY:.*]], label %[[WORKER_EXIT:.*]]
7369
// CHECK: %[[TMP6:.*]] = load ptr, ptr %[[TMP4]], align 8

mlir/test/Target/LLVMIR/omptarget-region-device-llvm.mlir

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,7 @@ module attributes {llvm.target_triple = "amdgcn-amd-amdhsa", omp.is_target_devic
3838
// CHECK: store ptr %[[ADDR_B]], ptr %[[TMP_B]], align 8
3939
// CHECK: %[[TMP_C:.*]] = alloca ptr, align 8
4040
// CHECK: store ptr %[[ADDR_C]], ptr %[[TMP_C]], align 8
41-
// CHECK: %[[KERNEL_LAUNCH_ENV_TMP:.*]] = alloca ptr, align 8
42-
// CHECK: store ptr %[[DYN_PTR]], ptr %[[KERNEL_LAUNCH_ENV_TMP]], align 8
43-
// CHECK: %[[KERNEL_LAUNCH_ENV:.*]] = load ptr, ptr %[[KERNEL_LAUNCH_ENV_TMP]], align 8
44-
// CHECK: %[[INIT:.*]] = call i32 @__kmpc_target_init(ptr @[[KERNEL_ENV]], ptr %[[KERNEL_LAUNCH_ENV]])
41+
// CHECK: %[[INIT:.*]] = call i32 @__kmpc_target_init(ptr @[[KERNEL_ENV]], ptr %[[DYN_PTR]])
4542
// CHECK-NEXT: %[[CMP:.*]] = icmp eq i32 %[[INIT]], -1
4643
// CHECK-NEXT: br i1 %[[CMP]], label %[[LABEL_ENTRY:.*]], label %[[LABEL_EXIT:.*]]
4744
// CHECK: [[LABEL_ENTRY]]:

0 commit comments

Comments
 (0)