Add docker push action #278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
in-progress
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ROCm 7.0 and 7.1 Docker images by creating two new Dockerfiles and a GitHub Actions workflow to build, push, and validate these images. The workflow allows for parameterized Triton commit versions and includes validation testing on both ROCm versions.
Key changes:
- Added
Dockerfile.rocm7.0andDockerfile.rocm7.1for newer ROCm versions - Created
docker-build-push.ymlworkflow to automate building and pushing Docker images to Docker Hub - Implemented validation tests that verify the images work correctly with Iris
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docker/Dockerfile.rocm7.1 | Dockerfile for ROCm 7.1 with Ubuntu 24.04, Python 3.12, and PyTorch 2.8.0 |
| docker/Dockerfile.rocm7.0 | Dockerfile for ROCm 7.0.2 with Ubuntu 24.04, Python 3.12, and PyTorch 2.8.0, includes ARG for Triton commit |
| .github/workflows/docker-build-push.yml | Workflow to build/push both ROCm 7.0 and 7.1 images to Docker Hub with validation tests |
mawad-amd
force-pushed
the
muhaawad/docker-images
branch
from
0fe0b89 to
04fbc36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist