Remove tabs to pass pre-commit
#2351
Conversation
|
Pre-commit passed but patch does not match with the |
|
The lines being removed in the patch have tabs, the fixes must be done on rocm-systems first. |
|
@erman-gurses do you want to do the fix in rocm-systems? i can too |
Yes, I will check that part too. |
Joseph has it here: ROCm/rocm-systems#2090 |
Oh nice, thanks for letting me know. Approved too. |
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
We can allow tabs in the patches/ folder as needed. I sent #2359 for that.
The lines being removed in the patch have tabs, the fixes must be done on rocm-systems first.
pre-commit is the only required check in TheRock right now. It must always pass. We shouldn't be merging through that failing check here or wait for cross-repository changes.
This fixes failures reported here: #2338 (comment) ``` No-tabs checker..........................................................Failed - hook id: forbid-tabs - exit code: 1 Tabs detected in file: patches/amd-mainline/rocm-systems/0002-Revert-hsakmt-bump-vgpr-count-for-gfx1151-1807.patch Error: Process completed with exit code 1. ``` We won't need #2351 once this is merged. Tested that the hook still runs for other directories: ``` Trim Trailing Whitespace.................................................Passed Fix End of Files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing core/0002-Revert-hsakmt-bump-vgpr-count-for-gfx1151-1807.patch Check Yaml...........................................(no files to check)Skipped Check for merge conflicts................................................Passed Check for added large files..............................................Passed Mixed line ending........................................................Passed black................................................(no files to check)Skipped clang-format.........................................(no files to check)Skipped mdformat.............................................(no files to check)Skipped No-tabs checker..........................................................Failed - hook id: forbid-tabs - exit code: 1 Tabs detected in file: core/0002-Revert-hsakmt-bump-vgpr-count-for-gfx1151-1807.patch ```
|
Closing since the problem was addressed in #2359 |
Remove tabs to pass pre-commit