Skip to content

Commit 63637fe

Browse files
committed
fix(is-ready max attempts): Stop checking map's readiness after reaching max attempts issue #/1445
1 parent b43e651 commit 63637fe

6 files changed

+10
-8
lines changed

dist/angular-google-maps.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1144,11 +1144,12 @@ Nicholas McCready - https://twitter.com/nmccready
11441144
return $timeout(function() {
11451145
if (retriesLeft <= 0) {
11461146
deferred.reject('Your maps are not found we have checked the maximum amount of times. :)');
1147+
return;
11471148
}
11481149
if (_ctr !== expectedInstances) {
1149-
return _checkIfReady(deferred, expectedInstances, retriesLeft - 1);
1150+
_checkIfReady(deferred, expectedInstances, retriesLeft - 1);
11501151
} else {
1151-
return deferred.resolve(_promises());
1152+
deferred.resolve(_promises());
11521153
}
11531154
}, 100);
11541155
};

dist/angular-google-maps.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-google-maps_dev_mapped.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1144,11 +1144,12 @@ Nicholas McCready - https://twitter.com/nmccready
11441144
return $timeout(function() {
11451145
if (retriesLeft <= 0) {
11461146
deferred.reject('Your maps are not found we have checked the maximum amount of times. :)');
1147+
return;
11471148
}
11481149
if (_ctr !== expectedInstances) {
1149-
return _checkIfReady(deferred, expectedInstances, retriesLeft - 1);
1150+
_checkIfReady(deferred, expectedInstances, retriesLeft - 1);
11501151
} else {
1151-
return deferred.resolve(_promises());
1152+
deferred.resolve(_promises());
11521153
}
11531154
}, 100);
11541155
};

dist/angular-google-maps_dev_mapped.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-google-maps_dev_mapped.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-google-maps_dev_mapped.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)