Automate spec08 task03 contiki interop tests #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
force-pushed
the
pr/automate0803
branch
4 times, most recently
from
21071dd to
8063ca3
Compare
miri64
reviewed
Oct 24, 2023
08-interop/test_spec08.py
Outdated
|
|
||
| # get the address of the contiki node, ie a substring after "-- " | ||
| res = contiki_node.cmd("ip-addr") | ||
| contiki_addr = res[res.find("-- ") + 3 :] |
There was a problem hiding this comment.
Let's make flake8 happy :-)
Suggested change
| contiki_addr = res[res.find("-- ") + 3 :] | |
| contiki_addr = res[(res.find("-- ") + 3):] |
There was a problem hiding this comment.
Come to think of it: don't you rather want to do it as a regex? E.g.
Suggested change
| contiki_addr = res[res.find("-- ") + 3 :] | |
| match = re.search("-- ...(.+)", res) | |
| assert match | |
| contiki_addr = match[1] |
MrKevinWeiss
force-pushed
the
pr/automate0803
branch
from
8063ca3 to
9bbc957
Compare
|
Ok, local tests worked and the static tests are happy. Anyone else have feedback? |
miri64
reviewed
Oct 26, 2023
08-interop/test_spec08.py
Outdated
| ) | ||
| def test_task03(riot_ctrl): | ||
| # run `./compile_contiki.sh` relative to this file | ||
| subprocess.check_call(["./compile_contiki.sh"], cwd=__file__[: __file__.rfind("/")]) |
There was a problem hiding this comment.
Let's make this more pythonic and portable
Suggested change
| subprocess.check_call(["./compile_contiki.sh"], cwd=__file__[: __file__.rfind("/")]) | |
| subprocess.check_call( | |
| ["./compile_contiki.sh"], | |
| cwd=os.path.dirname(os.path.realpath(__file__)), | |
| ) |
There was a problem hiding this comment.
Other than that, I think this is good to go
There was a problem hiding this comment.
Oops ya that makes sense
MrKevinWeiss
force-pushed
the
pr/automate0803
branch
from
9bbc957 to
dd8ee94
Compare
|
I just removed some unneeded copy pasta flags in the docker command in the contiki script |
MrKevinWeiss
force-pushed
the
pr/automate0803
branch
from
dd8ee94 to
e83224e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off the work @jia200x did.
Still a WIP but here are the issues I have found so far.
FLASHFILEto use the existingriotctrlinfrastructure butiotlabsactually usesBINFILEto speed things up... that took me a whileflash-onlystep maybe that could be cleanedThis is a quick (not really that quick) and dirty way and I would appreciate suggestions on how to clean it up.