-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/sam3: reworked timer driver #4891
Conversation
I like the code, periph/timer test passed, all periph/xtimer_* tests passed, so just wait for travis and go? |
yes, once you give your explicit ACK and Travis is green this can be merged :-) |
- made channel cc registers accessible as array
99fc1fe
to
9787046
Compare
Found a last-minute unclean line in the driver, the |
wow! yes, you're right, I really missed that. Yes, so travis should restart? |
it already went over the latest commit and is happy. Do you ack? |
yes! ACK and merge ;) |
may i ask for Makefile this application? |
While searching for the bug that was failing the
periph_timer
test, I decided to go for a hard cleanup. I decided to make only 3 channels per timer available for the following reasons:Further I reduced the amount of defined timers for the
udo
o andarudino-due
to 2, as normally 1 is used and 2 are idle, so now only 1 being unused should be enough for use cases where one wants to use an additional timer...So let the code size speak:
-> saves 588 byte and ~300 lines of code...