Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: allow the omission of the --filter argument #20010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david-vankampen
Copy link
Contributor

@david-vankampen david-vankampen commented Oct 23, 2023

This will allow the explicit omission of the --filter argument in the case of git servers that do not support filtering (reduces warnings on output)

Contribution description

If you provide a definition for the variable NO_GIT_FILTERING, then the --filter=blob:none argument to the git fetch operation will be omitted. This helps clean up occurrences of this message on build: warning: filtering not recognized by server, ignoring which makes the build output cleaner. I briefly perused git documentation to see if there is a way to test if the server supports filtering, but did not find anything, so I opted to allow the user to specify this on their own, if desired.

Testing procedure

I built with and without a definition of NO_GIT_FILTERING. The message warning: filtering not recognized by server, ignoring shows up in the log when it is NOT defined, and does not show up when it IS defined (in both cases I cleared out build/pkg to ensure it was doing a full fetch).

Issues/PRs references

N/A

…ervers that do not support filtering (reduces warnings on output)
@github-actions github-actions bot added Area: build system Area: Build system Area: pkg Area: External package ports labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: pkg Area: External package ports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant