Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build system: warn when soft FPU is used #19688

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

build system: warn when soft FPU is used #19688

wants to merge 24 commits into from

Conversation

maribu
Copy link
Member

@maribu maribu commented May 31, 2023

Contribution description

Add a test that warns when soft FPU is used and turn this warning into an error in the CI, unless GOOD_REASON_FOR_USING_FLOATS holds a non-empty string.

Testing procedure

The CI will do

Issues/PRs references

Hopefully this avoids #19614 becoming an annual "FPU which hunt" tradition

@maribu maribu added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: full build disable CI build filter CI: no fast fail don't abort PR build after first error labels May 31, 2023
@maribu maribu requested a review from kaspar030 as a code owner May 31, 2023 09:14
@github-actions github-actions bot added Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: doc Area: Documentation Area: tools Area: Supplementary tools labels May 31, 2023
@maribu maribu force-pushed the buildsystem-warn-float branch 3 times, most recently from bb46201 to b75a906 Compare May 31, 2023 10:45
@riot-ci
Copy link

riot-ci commented May 31, 2023 •
edited
Loading

Murdock results

❌ FAILED

e341b28 cpu/esp_common: disable FPU check

Build failures (12)
Application Target Toolchain Runtime (s) Worker
tests/drivers/adt7310 arduino-mega2560 gnu 1.16 tatooine
tests/drivers/adt7310 bluepill-stm32f103cb gnu 6.38 riotbuild-numa-2
tests/drivers/bmx055 arduino-mega2560 gnu 3.08 mobi3
tests/drivers/hih6130 arduino-mega2560 gnu 2.25 riotbuild-numa-2
tests/drivers/sdp3x arduino-mega2560 gnu 2.00 comsys-numa-1
tests/drivers/sdp3x bluepill-stm32f103cb gnu 1.61 tatooine
tests/pkg/arduino_adafruit_sensor arduino-mega2560 gnu 0.99 tatooine
tests/pkg/cn-cbor bluepill-stm32f103cb gnu 12.43 comsys-numa-0
tests/pkg/flatbuffers bluepill-stm32f103cb gnu 5.04 breeze
tests/sys/arduino arduino-mega2560 gnu 0.62 tatooine
tests/sys/rng arduino-mega2560 gnu 1.08 mobi7
tests/sys/rng bluepill-stm32f103cb gnu 4.85 mobi3

Artifacts

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: examples Area: Example Applications Area: sys Area: System Area: tests Area: tests and testing framework labels May 31, 2023
maribu added 16 commits May 31, 2023 23:35
@maribu
sys/nosoftfpu: add module to prevent linking against soft FPU functions
cd6f51e 
Note: Only tested with Cortex-M.

This is useful to track down the offenders pulling in the soft FPU
functions.
@maribu
tests/drivers/epd_bw_spi_disp_dev: fix accidental use of FPU
ab224f6
@maribu
drivers/hih6130: avoid using floats
9773d2f
@maribu
drivers/mq3: avoid use of floats
022179f
@maribu
drivers/sx127x: avoid using floats
122dab1
@maribu
pkg/lorabasics: avoid using floats
cfea675
@maribu
pkg/libschc: fix crazy use of FPU
de8d116
@maribu
tests/pkg/lvgl: avoid using floats
8417fb6
@maribu
tests/sys/bloom_bytes: avoid using floats
d0f9440
@maribu
sys/phydat: avoid use of floats
82dbc20 
A tiny look up table is both faster and way smaller in ROM size
than pulling in `pow()`.
@maribu
tests/sys/ps_schedstatistics: drop unused package
c1845c5 
`printf_float` seems to be unused but pulls in a lot of code. So
let's drop that.
@maribu
drivers: disable FPU check on legacy drivers
aa09742
@maribu
sys: disable FPU check on legitimate users
89efbcf
@maribu
pkg: disable FPU check on pkgs using FPU
ccdddb3
@maribu
tests: disable FPU check on legitimate users
66d4cc4
@maribu
examples: disable FPU check on legitimate users
f302c28
@github-actions github-actions bot added Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports labels May 31, 2023
@maribu maribu requested a review from gschorcht as a code owner May 31, 2023 21:44
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: drivers Area: Device drivers Area: examples Area: Example Applications Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: full build disable CI build filter CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maribu @riot-ci