-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netdev_default: migrate to netif_dev_default #19052
base: master
Are you sure you want to change the base?
Conversation
no idea why it was marked as a draft. This is ready for review |
06170ac
to
66515b9
Compare
66515b9
to
c52c8e6
Compare
sys/net/gnrc/Makefile.dep
Outdated
@@ -46,12 +46,12 @@ ifneq (,$(filter gnrc_lorawan_1_1,$(USEMODULE))) | |||
FEATURES_REQUIRED += periph_flashpage | |||
endif | |||
|
|||
ifneq (,$(filter gnrc_netdev_default,$(USEMODULE))) | |||
ifneq (,$(filter gnrc_netif_dev_default,$(USEMODULE))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably remain gnrc_netdev_default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh, that's a result of sed
. I will revert it.
Is there no fallback to include Do I understand it correctly that (Although those would also work on |
Yes, it was there, but it got replaced by
Exactly.
That would make sense. But since there are too many link layers, I just wanted to start with the baseline + IEEE 802.15.4. We could then migrate apps and tests as needed. |
done! |
ping. It seems this will be required for #19015 |
26a679b
to
3bdab84
Compare
Kconfig is not happy still |
This needs a rebase and Kconfig needs to be fixed. |
Good idea. I can add that while rebase |
Contribution description
This PR renames
netdev_default
tonetif_dev_default
due to the following reasons:netdev_default
is misleading.At the same time, this PR allows to define granularity for the kind of network interfaces (e.g select only IEEE 802.15.4 devices/interfaces). This is specially useful for test applications such as
ieee802154_hal
, which still require any IEEE 802.15.4 device but does not require other embedded network devices (e.g WiFi, Ethernet).So far, this PR only defines the
MODULE_NETIF_DEV_IEEE802154_DEFAULT
granularity, but we should add more on demand.Testing procedure
Compile tests should be enough. Make sure TEST_KCONFIG=1 and TEST_KCONFIG=0 builds converge.
Issues/PRs references
It will simplify merging #18472.