Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/nrf5x_common/periph_timer: fix spurious IRQs [backport 2022.10] #18974

Merged
merged 1 commit into from
Nov 25, 2022
Merged

cpu/nrf5x_common/periph_timer: fix spurious IRQs [backport 2022.10] #18974

merged 1 commit into from
Nov 25, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 25, 2022

Backport of #18970

Contribution description

As the title says

Testing procedure

The test in #18963 should now pass

Issues/PRs references

#18963

@maribu maribu added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 25, 2022
@maribu maribu mentioned this pull request Nov 25, 2022
Merged
@maribu maribu removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Nov 25, 2022
@maribu
Copy link
Member Author

maribu commented Nov 25, 2022

TODO: Wait for #18972 and #18973 to be merged, then rebase, then trigger the CI

@maribu maribu force-pushed the backport/2022.10/cpu/nrf5x_common/periph_timer/fix_spurious_irqs branch from e81926e to a66b3e2 Compare November 25, 2022 16:30
@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 25, 2022
@riot-ci
Copy link

riot-ci commented Nov 25, 2022

Murdock results

✔️ PASSED

a66b3e2 cpu/nrf5x_common/periph_timer: fix spurious IRQs

Success Failures Total Runtime
115836 0 115836 02h:20m:12s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

kaspar030
kaspar030 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport ACK.

@maribu maribu merged commit 6af713a into RIOT-OS:2022.10-branch Nov 25, 2022
@maribu maribu deleted the backport/2022.10/cpu/nrf5x_common/periph_timer/fix_spurious_irqs branch November 25, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen haukepetersen is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @riot-ci @kaspar030