-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/stm32: MCU implementation of the new GPIO API #14610
Open
gschorcht
wants to merge
11
commits into
RIOT-OS:master
Choose a base branch
from
gschorcht:periph/gpio_exp_v5b/cpu_stm32
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
cpu/stm32: MCU implementation of the new GPIO API #14610
gschorcht
wants to merge
11
commits into
RIOT-OS:master
from
gschorcht:periph/gpio_exp_v5b/cpu_stm32
+2,652
−377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
aabadie,
basilfx,
cgundogan,
DipSwitch,
fjmolinas,
haukepetersen,
jia200x,
leandrolanzieri,
MichelRottleuthner,
miri64,
MrKevinWeiss,
smlng and
vincent-d
as code owners
July 24, 2020 15:31
gschorcht
added
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
State: WIP
State: The PR is still work-in-progress and its code is not in its final presentable form yet
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Jul 24, 2020
gschorcht
force-pushed
the
periph/gpio_exp_v5b/cpu_stm32
branch
3 times, most recently
from
July 25, 2020 15:27
61eb5ac
to
273d83f
Compare
gschorcht
force-pushed
the
periph/gpio_exp_v5b/cpu_stm32
branch
3 times, most recently
from
July 26, 2020 11:01
9417a82
to
78f136f
Compare
gschorcht
removed
the
State: WIP
State: The PR is still work-in-progress and its code is not in its final presentable form yet
label
Jul 26, 2020
gschorcht
force-pushed
the
periph/gpio_exp_v5b/cpu_stm32
branch
from
July 26, 2020 15:14
78f136f
to
b37428f
Compare
gschorcht
added
the
CI: run tests
If set, CI server will run tests on hardware for the labeled PR
label
Jul 26, 2020
gschorcht
force-pushed
the
periph/gpio_exp_v5b/cpu_stm32
branch
from
September 3, 2020 07:29
b37428f
to
2f4e83f
Compare
This change is a temporary patch to fix the compilation errors with the STM32 MCU implementation of the new low-level GPIO API until PR #3 for micropython is merged. Once this PR is merged, this patch can be dropped.
gschorcht
force-pushed
the
periph/gpio_exp_v5b/cpu_stm32
branch
from
September 3, 2020 07:44
89c4302
to
15b76a8
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
State: The issue / PR has no activity for >185 days
label
Mar 19, 2021
gschorcht
added
State: don't stale
State: Tell state-bot to ignore this issue
and removed
State: stale
State: The issue / PR has no activity for >185 days
labels
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: cpu
Area: CPU/MCU ports
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
CI: run tests
If set, CI server will run tests on hardware for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
State: don't stale
State: Tell state-bot to ignore this issue
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides the MCU implementation of the low-level GPIO API in PR #14602 for STM32. It also contains necessary changes for STM32 boards.
This PR depends on and includes PR #14602. Only the commits from bd0b266 and f1f6cae are new in this PR.
Testing procedure
The following tests should be executed:
tests/periph_gpio_exp
to any STM32F1 board and test whether basic GPIO functionality is still working.tests/periph_gpio_exp
to any STM32 board and test whether basic GPIO functionality is still working.make -C tests/periph_gpio_exp test
on any STM32F1 board to test whether the redirection to virtual GPIO expanders ports works correctly.make -C tests/periph_gpio_exp test
on any STM32 board to test whether the redirection for virtual GPIO expanders ports works correctly.tests/periph_adc
on any STM32L4 board to check whether ADC is still working.examples/micropython
, connect D9 (PC7) with D6 (PB10) and execute the following python instructions to test correct pin mapping in micropython:The following tests might be skipped because the according peripheral is changed only slightly so that it might be enough to review the change. In these cases, only
pin == GPIO_UNDEF
andpin != GPIO_UNDEF
were replaced bygpio_is_undef(pin)
and!gpio_is_undef(pin)
, respectively.tests/periph_adc
on any STM32F1 board to check whether ADC is still working.tests/periph_adc
on any STM32L1 board to check whether ADC is still working.tests/conn_can
on any STM32 board that supports CAN to check whether CAN is still working.tests/periph_i2c
on any STM32F1 board to check whether I2C is still working.tests/periph_pwm
on any STM32 board to test whether PWM is still working.tests/periph_qdec
on any STM32 board that supports QDEC to check whether QDEC is still working.tests/periph_uart
on any STM32 board to check whether UART is still working.Issues/PRs references
Depends on PR #14602