Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples / tests: LoRa tests fail on platforms that don't support LoRa #14520

Open
miri64 opened this issue Jul 15, 2020 · 3 comments
Open

examples / tests: LoRa tests fail on platforms that don't support LoRa #14520

miri64 opened this issue Jul 15, 2020 · 3 comments
Assignees
Labels
Area: LoRa Area: LoRa radio support Area: tests Area: tests and testing framework Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@miri64
Copy link
Member

miri64 commented Jul 15, 2020

Description

The tests introduced in #11915 fail for non-LoRa platforms. See also RIOT-OS/Release-Specs#156 (comment) task 2 and 3.

Steps to reproduce the issue

$ BOARD=iotlab-m3 make -C examples/lorawan/ flash
...
$ BOARD=iotlab-m3 make -C examples/lorawan/ test
$ BOARD=iotlab-m3 make -C tests/pkg_semtech-loramac/ flash
...
$ BOARD=iotlab-m3 make -C tests/pkg_semtech-loramac/ test

Expected results

The tests are ignored or marked as expected to fail.

Actual results

The tests fail.

Versions

2020.07-RC1

Operating System Environment
----------------------------
         Operating System: "Arch Linux" 
                   Kernel: Linux 5.7.7-arch1-1 x86_64 unknown
             System shell: GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
             make's shell: GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)

Installed compiler toolchains
-----------------------------
               native gcc: gcc (GCC) 10.1.0
        arm-none-eabi-gcc: arm-none-eabi-gcc (Arch Repository) 10.1.0
                  avr-gcc: missing
         mips-mti-elf-gcc: missing
               msp430-gcc: missing
     riscv-none-embed-gcc: missing
     xtensa-esp32-elf-gcc: missing
   xtensa-esp8266-elf-gcc: missing
                    clang: clang version 10.0.0 

Installed compiler libs
-----------------------
     arm-none-eabi-newlib: "3.3.0"
      mips-mti-elf-newlib: missing
  riscv-none-embed-newlib: missing
  xtensa-esp32-elf-newlib: missing
xtensa-esp8266-elf-newlib: missing
                 avr-libc: missing (missing)

Installed development tools
---------------------------
                   ccache: missing
                    cmake: cmake version 3.17.3
                 cppcheck: missing
                  doxygen: 1.8.18
                      git: git version 2.27.0
                     make: GNU Make 4.3
                  openocd: Open On-Chip Debugger 0.10.0+dev-01089-g3bfe49266 (2020-02-26-14:18)
                   python: Python 3.8.3
                  python2: Python 2.7.18
                  python3: Python 3.8.3
                   flake8: 3.8.3 (mccabe: 0.6.1, pycodestyle: 2.6.0, pyflakes: 2.2.0) CPython 3.8.3 on
               coccinelle: missing
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework Area: LoRa Area: LoRa radio support labels Jul 15, 2020
@miri64 miri64 added this to the Release 2020.07 milestone Jul 15, 2020
@aabadie
Copy link
Contributor

aabadie commented Jul 15, 2020

This test is blacklisted on CI because it requires more setup (a lorawan gateway for instance):

# Can't be run on ci since it requires gateway + lora node
TEST_ON_CI_BLACKLIST = all

It's just that compile_and_test_for_board.py doesn't take this into account apparently.

@miri64
Copy link
Member Author

miri64 commented Jul 15, 2020

It's just that compile_and_test_for_board.py doesn't take this into account apparently.

Yes, for other (e.g. driver) tests that works however.

@fjmolinas
Copy link
Contributor

It's just that compile_and_test_for_board.py doesn't take this into account apparently.

Yes, for other (e.g. driver) tests that works however.

And for other drivers it fails or triggers hardfaults like groove_ledbar, I think this test is just one of many that fall under the issues partially addressed in #11954, and this one in particular is addressed perfectly by that, its a PR I would like to revive if it gets more support.

@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LoRa Area: LoRa radio support Area: tests Area: tests and testing framework Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

4 participants