boards/hifive1: flashing issue

[kaspar030]

Description

@fjmolinas realizied that the hifive1 shows a flasing issue.
Somehow, the boards gets into a state where openocd cannot flash it anymore.

There's a "safe bootloader mode" that can be entered by flashing the reset button twice (second time when the led blinks green, after which the led should pulse in red, indicating safe mode). In this the board can be flashed again. Unfortunately that's a manual procedure and thus makes the board unusable in CI or automated testing...

I've bisected the issue to this commit: 547ebd1

Steps to reproduce the issue

1. BOARD=hifive1 make -Cexamples/hello-world make flash
2. if it succeeds (depends on previous state), try a second time, should fail

Expected results

Flashing succeeds.

Actual results

Flashing fails.

Versions

Operating System Environment
-----------------------------
         Operating System: "Arch Linux" 
                   Kernel: Linux 5.4.3-arch1-1 x86_64 unknown
             System shell: GNU bash, version 5.0.11(1)-release (x86_64-pc-linux-gnu)
             make's shell: GNU bash, version 5.0.11(1)-release (x86_64-pc-linux-gnu)

Installed compiler toolchains
-----------------------------
               native gcc: gcc (GCC) 9.2.0
        arm-none-eabi-gcc: arm-none-eabi-gcc (Arch Repository) 9.2.0
                  avr-gcc: avr-gcc (GCC) 9.2.0
         mips-mti-elf-gcc: mips-mti-elf-gcc (Codescape GNU Tools 2018.09-03 for MIPS MTI Bare Metal) 6.3.0
               msp430-gcc: missing
     riscv-none-embed-gcc: riscv-none-embed-gcc (GNU MCU Eclipse RISC-V Embedded GCC, 64-bit) 8.1.0
     xtensa-esp32-elf-gcc: missing
   xtensa-esp8266-elf-gcc: missing
                    clang: clang version 9.0.0 (tags/RELEASE_900/final)

Installed compiler libs
-----------------------
     arm-none-eabi-newlib: "3.1.0"
      mips-mti-elf-newlib: "2.5.0"
  riscv-none-embed-newlib: "3.0.0"
  xtensa-esp32-elf-newlib: missing
xtensa-esp8266-elf-newlib: missing
                 avr-libc: "2.0.0" ("20150208")

Installed development tools
---------------------------
                   ccache: ccache version 3.7.6
                    cmake: cmake version 3.16.1
                 cppcheck: Cppcheck 1.89
                  doxygen: 1.8.16
                      git: git version 2.24.1
                     make: GNU Make 4.2.1
                  openocd: Open On-Chip Debugger 0.10.0+dev-00103-g352e6b82-dirty (2019-02-21-09:45)
                   python: Python 3.8.0
                  python2: Python 2.7.17
                  python3: Python 3.8.0
                   flake8: 3.7.9 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.8.0 on Li

Current master, self compiled openocd, on arch linux.

[kaspar030]

@fjmolinas this seems to be the issue for our hifive1 problems...

[kaspar030]

@kenrabold any clue what could cause this? The change seems OK.

[aabadie]

is it possible to add something like:

reset_config srst_only connect_assert_srst

?

[kaspar030]

reset_config srst_only connect_assert_srst

Doesn't help, but shows Warn : 'srst_nogate' reset_config option is required.

[maribu]

Ping?