Skip to content

Commit f0708d6

Browse files
cladmijcarrano
authored andcommitted
serial: remove unneccesary exports
There variables are only used directly in the main Makefile.include or in application makefiles. So there is no need to export the value. Not exporting will also prevent evaluating them for no reason when 'term' is not done.
1 parent 58500f9 commit f0708d6

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

makefiles/tools/serial.inc.mk

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,13 @@ endif
88
ifeq ($(PORT),)
99
$(info Warning: no PORT set!)
1010
endif
11-
export PORT
12-
1311
export BAUD ?= 115200
1412

1513
RIOT_TERMINAL ?= pyterm
1614
ifeq ($(RIOT_TERMINAL),pyterm)
17-
export TERMPROG ?= $(RIOTTOOLS)/pyterm/pyterm
18-
export TERMFLAGS ?= -p "$(PORT)" -b "$(BAUD)"
15+
TERMPROG ?= $(RIOTTOOLS)/pyterm/pyterm
16+
TERMFLAGS ?= -p "$(PORT)" -b "$(BAUD)"
1917
else ifeq ($(RIOT_TERMINAL),picocom)
20-
export TERMPROG ?= picocom
21-
export TERMFLAGS ?= --nolock --imap lfcrlf --echo --baud "$(BAUD)" "$(PORT)"
18+
TERMPROG ?= picocom
19+
TERMFLAGS ?= --nolock --imap lfcrlf --echo --baud "$(BAUD)" "$(PORT)"
2220
endif

makefiles/vars.inc.mk

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ export GIT_CACHE_DIR # path to git-cache cache directory
7171
export FLASHER # The command to call on "make flash".
7272
export FFLAGS # The parameters to supply to FLASHER.
7373
export FLASH_ADDR # Define an offset to flash code into ROM memory.
74-
export TERMPROG # The command to call on "make term".
75-
export TERMFLAGS # Additional parameters to supply to TERMPROG.
76-
export PORT # The port to connect the TERMPROG to.
74+
# TERMPROG # The command to call on "make term".
75+
# TERMFLAGS # Additional parameters to supply to TERMPROG.
76+
# PORT # The port to connect the TERMPROG to.
7777
export ELFFILE # The unstripped result of the compilation.
7878
export HEXFILE # The stripped result of the compilation.
7979
export DEBUGGER # The command to call on "make debug", usually a script starting the GDB front-end.

0 commit comments

Comments
 (0)