WIP: Add problemMatching to task#989
Merged
renkun-ken merged 5 commits intoREditorSupport:masterfrom Feb 13, 2022
gowerc:tasks
Merged
WIP: Add problemMatching to task#989renkun-ken merged 5 commits intoREditorSupport:masterfrom gowerc:tasks
renkun-ken merged 5 commits intoREditorSupport:masterfrom
gowerc:tasks
Conversation
Member
|
I test the implementation and it works as expected. When some test cases fail, the errors with proper message and location will show up in the diagnostics. When the problem is fixed and run tests again, the errors will disappear. As for the tests of these tasks, I suggest that we could discuss it in a separate issue (#990) about how we could add more useful tests of vscode-R extension in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Wanted to try and incorporate problemMatching into the default
R: testtask to make it easier to find test failures when testing a R package. The change so far seems to be working (see screenshot below).That being said I'm not sure how to test this. I was thinking about setting up a dummy repo and running the task inside of it but I can't quite work out how to do that... I had tried
But that doesn't seem to work. My next idea was to try and extract the regex patterns and see if they work aginst pre-defined error messages but I couldn't figure out the api for getting access to them. Any advice here would be appreciated !