Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location message changes #660

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Location message changes #660

merged 2 commits into from
Mar 10, 2025

Conversation

sushant-thotakura1
Copy link
Contributor

@sushant-thotakura1 sushant-thotakura1 commented Feb 21, 2025

  • Replaced - as the separator and added | because there might be negative lat and long

Details of Feature/Bug

  • Location pin giving wrong lat-longs
  • As there are chances of lat-longs to be negative, the seprator - is causing issue while fetching the lat longs.

List of changes

  • The sperator is changed to | from - to handle these scenarios better.

Database migration/schema changes (if any)

  • N/A

Self review checklist

  • Ran all the tests locally to check that you have not introduced any new regression.
  • Followed coding and styling guidelines. Checked for ESLint fixes.
  • Checked for any dependencies and updated them.
  • Made sure to add the comments where required.
  • Added the PR link to the ticket assigned.
  • Make sure you have updated (if necessary)-
    • Documentation (if any)
    • Noted version number
    • Added the label in the PR
    • Created release notes

Additional info (if any)

  • Add anything you feel worth mentioning...

- Replaced - as the separator and added | because there might be negative lat and long
@Pallavi17101997 Pallavi17101997 merged commit 3c8954a into develop Mar 10, 2025
7 checks passed
@Pallavi17101997 Pallavi17101997 deleted the botswana-location-bug branch March 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants