make SPARQLConnector work with DBpedia #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also unskips an old test on travis tha otherwise failed locally due to now unresolved SPARQLWrapper exception ref
joernhees
added
bug
|
My gut feel would be to strip off the Will we have one plugin for utf-8, one for utf-16? But whatever, I don't care that deeply :D |
|
close & reopen to trigger travis... |
|
yupp, actually thought about that, but didn't find the right spot quickly... also question is: what if the encoding is different, how to handle that correctly? I'll merge for now as a quick-fix is better than none, but feel free to cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think this was a leftover from #744
DBpedia seems to answer with
application/sparql-results+xml; charset=UTF-8header, which wasn't registered in plugins...also unskips an old test on travis tha otherwise failed locally due to now unresolved SPARQLWrapper exception ref