Skip to content

Conversation

@aucampia
Copy link
Member

@aucampia aucampia commented Apr 9, 2023

Summary of changes

This change narrows import so that things are imported from the Python module where they are defined instead of importing them from a module that re-exports them, e.g. change import of Graph to import from the rdflib.graph module instead of from the rdflib module. This helps avoid problems with circular imports.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This change narrows import so that things are imported from the Python module
where they are defined instead of importing them from a module that re-exports
them, e.g. change import of `Graph` to import from the `rdflib.graph` module
instead of from the `rdflib` module. This helps avoid problems with circular
imports.
@coveralls
Copy link

Coverage Status

Coverage: 90.831% (-0.0004%) from 90.832% when pulling eec6c24 on aucampia:iwana-20230409T1848-narrow_imports into 4940798 on RDFLib:main.

@aucampia aucampia marked this pull request as ready for review April 9, 2023 18:10
@aucampia aucampia requested a review from a team April 9, 2023 18:11
@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. refactor This issue concerns a change that neither fixes a bug nor adds a feature. labels Apr 9, 2023
@aucampia
Copy link
Member Author

Merging without review, as this does not change runtime behaviour.

@aucampia aucampia merged commit 61f8a8d into RDFLib:main Apr 10, 2023
@aucampia aucampia deleted the iwana-20230409T1848-narrow_imports branch June 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge The PR will be merged soon if no further feedback is provided. refactor This issue concerns a change that neither fixes a bug nor adds a feature. review wanted This indicates that the PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants