minor code style and linting

Author: joernhees

cluster.py

@@ -359,7 +359,7 @@ def expected_precision_loss_by_query_reduction(
     """
     max_score = gtp_scores.score
     variant_max_k_prec_loss_reps = defaultdict(OrderedDict)
-    for max_k_idx, max_k in enumerate(max_ks):
+    for max_k in max_ks:
         # TODO: try other (non clustering) algorithms to improve set coverage
         # TODO: picking fittest representative might be non-optimal solution
         cluster_variants = make_cluster_variants_for_gps_by_precision(
@@ -381,8 +381,8 @@ def expected_precision_loss_by_query_reduction(
                 'Precision loss for max %d requests in clustering %s: %0.3f',
                 max_k, cv_name, lost_precision
             )
-            variant_max_k_prec_loss_reps[cv_name][max_k] = \
-                (lost_precision / max_score, gp_reps)
+            variant_max_k_prec_loss_reps[cv_name][max_k] = (
+                lost_precision / max_score, gp_reps)
 
     log_msg = ['Best clusterings (least precision loss) per k requests:']
     for k in max_ks:

fusion/trained.py

@@ -99,7 +99,7 @@ def crossval_fm_score_single_split(
                 vecs[test_idxs], labels[test_idxs], groups[test_idxs],
                 clf=clf
         )
-    except Exception as e:
+    except Exception:
         logger.warning(
             '%s: param %d/%d: CV split %d/%d: caused an exception\nparams: %s',
             fm.name, params_number, n_params, split, n_splits, params,

gp_learner.py

@@ -285,7 +285,7 @@ def mate_helper(
     assert isinstance(overlap, set)
     assert isinstance(delta_dom, set)
     assert isinstance(delta_other, set)
-    for i in range(retries):
+    for _ in range(retries):
         overlap_part = [t for t in overlap if random.random() < pb_overlap]
         dom_part = [t for t in delta_dom if random.random() < pb_dom]
         other_part = [t for t in delta_other if random.random() < pb_other]
@@ -629,6 +629,10 @@ def mutate_fix_var(
     fitness. By randomizing the subset size, we will eventually (and more
     likely) select other combinations of remaining GTPs.
 
+    :param sparql: SPARQLWrapper endpoint.
+    :param timeout: Timeout in seconds for each individual query (gp).
+    :param gtp_scores: Current GTPScores object for sampling.
+    :param child: a graph pattern to mutate.
     :param gtp_sample_max_n: Maximum GTPs subset size to base fixations on.
     :param rand_var: If given uses this variable instead of a random one.
     :param sample_max_n: Maximum number of children.

gp_query.py

@@ -165,6 +165,8 @@ def query_stats(guard):
                     )
                 _query_stats_last_adapt = deepcopy(_query_stats)
         return _query_stats, bs
+
+
 _query_stats = _QueryStats()
 _query_stats_last_adapt = _QueryStats()
 
@@ -303,7 +305,7 @@ def _multi_query_wrapper(*args, **kwds):
                 closed.pop()
         try:
             return func(*args, **kwds)
-        except:
+        except Exception:
             closed.append(datetime.utcnow())
             raise
     return _multi_query_wrapper

prediction_baselines.py

@@ -185,7 +185,7 @@ def predict_target_with_milne_witten(
             / (lN - log(min(s_indeg, t_indeg)))
         )
         scores[t] = mw
-    res = scores.most_common()
+    # res = scores.most_common()
     # for t, mw in res[:10]:
     #     print('\t', mw, t)
     return scores.most_common()

utils.py

@@ -61,7 +61,8 @@ def curify(self, identifier):
             self.prefixes[prefix] = ns_n3
         return res
 
-    def decurify(self, n3_str):
+    @staticmethod
+    def decurify(n3_str):
         return decurify(n3_str)
 
     @staticmethod