fix: fix a resource a type error when using async _resolved function #7426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e22493 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
added 2 commits
March 15, 2025 14:43
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
Author
|
@maiieul please help me to review |
maiieul
reviewed
Apr 24, 2025
This commit refactors the preloader and bundle graph handling to improve performance and maintainability. Key changes include: - Removed `qwikloader-prefetch.ts` and `qwikloader-entry.ts` as they are no longer needed. - Updated the preloader configuration to use more descriptive variable names and optimized preload probabilities. - Changed the bundle graph output from `.js` to `.json` for better clarity and compression. - Added a new test for the preloader script to ensure its integrity and size. - Updated API Extractor configurations across multiple packages to use consistent naming and newline settings. These changes aim to enhance the efficiency of Qwik's preloading mechanism and ensure better maintainability of the codebase.
wmertens
reviewed
Apr 25, 2025
Member
wmertens
left a comment
wmertens
left a comment
There was a problem hiding this comment.
Can you explain more why this is needed? A Resource is supposed to be a placeholder for a Promise, so I don't understand why it should also return a Promise
Contributor
Author
Member
|
@JerryWu1234 can you merge main and run |
Member
Done ✅ |
gioboa
reviewed
Sep 9, 2025
gioboa
approved these changes
Sep 9, 2025
gioboa
reviewed
Sep 9, 2025
Member
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks @JerryWu1234 for your incredible help and passion ❤️
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
fixes: #7086
follow version 2 to fix this ts error
Description
Checklist
pnpm change