Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Refine jsx types #4402

Merged
merged 3 commits into from
Jun 5, 2023
Merged

types: Refine jsx types #4402

merged 3 commits into from
Jun 5, 2023

Conversation

FlatMapIO
Copy link
Contributor

@FlatMapIO FlatMapIO commented Jun 3, 2023 •
edited
Loading

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Supplement event type declarations in jsx-qwik-events, resolve #4369

  • nativeEvent in BaseSyntheticEvent is always undefined at runtime. For now, mark it as E | undefined
  • Add isComposing property in QwikKeyboardEvent
  • Add enterKeyHint to TextareaHTMLAttributes

Use cases and why

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Jun 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@FlatMapIO FlatMapIO changed the title Refine jsx-qwik-events Refine jsx-qwik-events type declare Jun 3, 2023
@FlatMapIO FlatMapIO changed the title Refine jsx-qwik-events type declare types: Refine jsx-qwik-events type declare Jun 3, 2023
@FlatMapIO FlatMapIO changed the title types: Refine jsx-qwik-events type declare types: Refine jsx types Jun 3, 2023
@manucorporat
Copy link
Contributor

This is great improvement! thank you!

@manucorporat manucorporat merged commit 1099a11 into QwikDev:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] QwikKeyboardEvent missing isComposing property
2 participants
@FlatMapIO @manucorporat