Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve docs #1239

Merged
merged 10 commits into from
Sep 15, 2022
Merged

docs: Improve docs #1239

merged 10 commits into from
Sep 15, 2022

Conversation

manucorporat
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gitguardian
Copy link

gitguardian bot commented Sep 14, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2584471 Generic High Entropy Secret e17e6d2 packages/docs/src/routes/index.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 14, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 95c6ced
Status: ✅  Deploy successful!
Preview URL: https://fa5cc781.qwik-docs.pages.dev
Branch Preview URL: https://improve-docs.qwik-docs.pages.dev

View logs

@manucorporat manucorporat enabled auto-merge (squash) September 15, 2022 14:43
@manucorporat manucorporat merged commit 8aba42c into main Sep 15, 2022
@manucorporat manucorporat deleted the improve-docs branch September 15, 2022 14:57
@manucorporat manucorporat restored the improve-docs branch September 15, 2022 15:14
@adamdbradley adamdbradley deleted the improve-docs branch October 3, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant