Merge pull request #7850 from maiieul/disable-rollup-transitive-imports-by-default

fix: hoisted transitive imports mess up the bundle-graph static imports graph

Author: wmertens

.changeset/hot-buses-strive.md

@@ -0,0 +1,5 @@
+---
+'@builder.io/qwik': patch
+---
+
+FIX: Rollup's hoistTranstiveImports is now set to `false` because the hoisting added unnecessary bundles to be preloaded to the bundle-graph static imports graph. This could lead to a suboptimal preloading experience.

packages/qwik/src/optimizer/src/plugins/rollup.ts

@@ -243,6 +243,12 @@ export function normalizeRollupOutputOptionsObject(
     outputOpts.exports = 'auto';
   }
 
+  /**
+   * Transitive imports must not be hoisted. Otherwise, the bundle-graph static imports will be
+   * incorrect; leading to over-preloading.
+   */
+  outputOpts.hoistTransitiveImports = false;
+
   return outputOpts;
 }
 

packages/qwik/src/optimizer/src/plugins/vite.ts

@@ -323,9 +323,6 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
              * https://github.com/QwikDev/qwik/issues/7226#issuecomment-2647122505
              */
             maxParallelFileOps: 1,
-            output: {
-              manualChunks: qwikPlugin.manualChunks,
-            },
             // temporary fix for rolldown-vite types
           } as BuildOptions['rollupOptions'],
         },