Skip to content

Commit ab82aa6

Browse files
committed
Allow %target-run-simple-swift to optionally take arbitrary driver args.
1 parent a9ebbd3 commit ab82aa6

File tree

2 files changed

+10
-18
lines changed

2 files changed

+10
-18
lines changed

test/Interpreter/strong_retain_unowned_mispairing.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %target-run-simple-opt-O-swift
1+
// RUN: %target-run-simple-swift(-O)
22
// REQUIRES: executable_test
33

44
// We were crashing here due to not preserving rc identity.

test/lit.cfg

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ config.target_runtime = "unknown"
576576
swift_reflection_test_name = 'swift-reflection-test' + config.variant_suffix
577577

578578
def use_interpreter_for_simple_runs():
579-
def make_simple_target_run(gyb=False, stdlib=False, opt=""):
579+
def make_simple_target_run(gyb=False, stdlib=False, parameterized=False):
580580
result = ''
581581
if gyb:
582582
result += ('%empty-directory(%t) && '
@@ -592,8 +592,8 @@ def use_interpreter_for_simple_runs():
592592
swift_execution_tests_extra_flags))
593593
if stdlib:
594594
result += '-Xfrontend -disable-access-control '
595-
if opt:
596-
result += opt + ' '
595+
if parameterized:
596+
result += ' \\1 '
597597
if gyb:
598598
result += '%t/main.swift'
599599
else:
@@ -602,9 +602,8 @@ def use_interpreter_for_simple_runs():
602602
config.target_run_stdlib_swiftgyb = make_simple_target_run(gyb=True)
603603
config.target_run_simple_swiftgyb = make_simple_target_run(gyb=True)
604604
config.target_run_stdlib_swift = make_simple_target_run(stdlib=True)
605-
config.target_run_simple_opt_Osize_swift = make_simple_target_run(opt='-Osize')
606-
config.target_run_simple_opt_O_swift = make_simple_target_run(opt='-O')
607605
config.target_run_simple_swift = make_simple_target_run()
606+
config.target_run_simple_swift_parameterized = make_simple_target_run(parameterized=True)
608607
config.available_features.add('interpret')
609608

610609
if run_vendor == 'apple':
@@ -1081,21 +1080,15 @@ config.substitutions.append(('%sftp-server',
10811080

10821081

10831082
if not getattr(config, 'target_run_simple_swift', None):
1084-
config.target_run_simple_swift = (
1085-
'%%empty-directory(%%t) && '
1086-
'%s %s %%s -o %%t/a.out -module-name main && '
1087-
'%s %%t/a.out &&'
1088-
'%s %%t/a.out'
1089-
% (config.target_build_swift, mcp_opt, config.target_codesign, config.target_run))
1090-
config.target_run_simple_opt_O_swift = (
1083+
config.target_run_simple_swift_parameterized = (
10911084
'%%empty-directory(%%t) && '
1092-
'%s %s -O %%s -o %%t/a.out -module-name main && '
1085+
'%s %s %%s \\1 -o %%t/a.out -module-name main && '
10931086
'%s %%t/a.out &&'
10941087
'%s %%t/a.out'
10951088
% (config.target_build_swift, mcp_opt, config.target_codesign, config.target_run))
1096-
config.target_run_simple_opt_Osize_swift = (
1089+
config.target_run_simple_swift = (
10971090
'%%empty-directory(%%t) && '
1098-
'%s %s -Osize %%s -o %%t/a.out -module-name main && '
1091+
'%s %s %%s -o %%t/a.out -module-name main && '
10991092
'%s %%t/a.out &&'
11001093
'%s %%t/a.out'
11011094
% (config.target_build_swift, mcp_opt, config.target_codesign, config.target_run))
@@ -1189,9 +1182,8 @@ config.substitutions.append(('%target-swift-frontend', config.target_swift_front
11891182

11901183

11911184
config.substitutions.append(('%target-run-simple-swiftgyb', config.target_run_simple_swiftgyb))
1185+
config.substitutions.append(('%target-run-simple-swift\(([^)]+)\)', config.target_run_simple_swift_parameterized))
11921186
config.substitutions.append(('%target-run-simple-swift', config.target_run_simple_swift))
1193-
config.substitutions.append(('%target-run-simple-opt-O-swift', config.target_run_simple_opt_O_swift))
1194-
config.substitutions.append(('%target-run-simple-opt-Osize-swift', config.target_run_simple_opt_Osize_swift))
11951187
config.substitutions.append(('%target-run-stdlib-swiftgyb', config.target_run_stdlib_swiftgyb))
11961188
config.substitutions.append(('%target-run-stdlib-swift', config.target_run_stdlib_swift))
11971189
config.substitutions.append(('%target-repl-run-simple-swift', subst_target_repl_run_simple_swift))

0 commit comments

Comments
 (0)