Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PacketByteBuf and friends LE/BE #633

Open
ix0rai opened this issue Aug 21, 2024 · 0 comments
Open

PacketByteBuf and friends LE/BE #633

ix0rai opened this issue Aug 21, 2024 · 0 comments
Labels
s: small PRs with less than 200 lines t: javadoc this pull request updates or adds new javadoc t: refactor proposes a refactor

Comments

@ix0rai
Copy link
Member

ix0rai commented Aug 21, 2024

All the LE/BE in this, BufferHelper, and RconClient should be Le/Be.
They should also probably have javadocs saying they stand for little/big endian (I assume).

Originally posted by @supersaiyansubtlety in #630 (comment)
@ix0rai ix0rai added t: javadoc this pull request updates or adds new javadoc s: small PRs with less than 200 lines t: refactor proposes a refactor labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s: small PRs with less than 200 lines t: javadoc this pull request updates or adds new javadoc t: refactor proposes a refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ix0rai