Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QLoom >=1.3.1 doesnt remove transitive fabric dependencies #40

Open
SilverAndro opened this issue Aug 13, 2023 · 6 comments
Open

QLoom >=1.3.1 doesnt remove transitive fabric dependencies #40

SilverAndro opened this issue Aug 13, 2023 · 6 comments

Comments

@SilverAndro
Copy link

if you pull in a dependency that uses fabric loader or fabric api, those dependencies are removed with qloom 1.2.3, but upgrading to 1.3.1 or later results in them not being removed, breaking running the game from the dev env

1.2.3:
image

1.3.1 (and later):
image

@TheGlitch76
Copy link
Contributor

Yeah, I'm not sure what's going on here. It's the same patch as in 1.2.3

For now, you can exclude fabric deps manually:

project.configurations.all {
  exclude(group: "net.fabricmc", module: "fabric-loader")
  exclude(group: "net.fabricmc.fabric-api")
}

@KrLite
Copy link

KrLite commented Oct 2, 2023

Yeah, I'm not sure what's going on here. It's the same patch as in 1.2.3

For now, you can exclude fabric deps manually:

project.configurations.all {
  exclude(group: "net.fabricmc", module: "fabric-loader")
  exclude(group: "net.fabricmc.fabric-api")
}

Hi! I'm experiencing the same issue with quilt-loom 1.3.+. The solution you provided works, but only for Quilt-only projects, since all classes from Fabric API will be unaccessible by java, causing all the code referencing Fabric API not passing the task compileJava.

As I'm not good on groovy at all, is there any other way to fix this problem besides downgrading the Quilt Loom version? Or, when can this issue be fixed in Quilt Loom?

@AlexIIL
Copy link

AlexIIL commented Oct 2, 2023

So you should be able to remove the exclude(group: "net.fabricmc.fabric-api") line to make it only exclude fabric-loader - that way you can still depend on fabric api?

@KrLite
Copy link

KrLite commented Oct 2, 2023

I've tried this but this is actually causing the... duplicate of Fabric API.

image

But this is the closest attempt to launch.

@KrLite
Copy link

KrLite commented Oct 2, 2023

It shows that Fabric API is embedded inside the Quilted Fabric API and that's true. But in development environment, compileJava cannot recognize them, although no errors were emitted and you can still manually check these jars, existing.

@KrLite
Copy link

KrLite commented Oct 2, 2023

Now a new problem occurs, that is whatever the version of Quilt Loom I'm using, the Fabric API seems always unaccessible to the java compiler (I'm not excluding Fabric API neither excluding Fabric Loader). Is this another issue inside the Quilt toolchain? Recently with Quilt I've encountered many things I didn't used to understand...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants