Skip to content

Commit 15890c0

Browse files
committed
fix: improve telemetry
1 parent a703a5f commit 15890c0

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

src/query_farm_telemetry.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,7 @@ INTERNAL_FUNC void QueryFarmSendTelemetry(ExtensionLoader &loader, const string
4646
return;
4747
}
4848

49-
auto db = loader.GetDatabaseInstance().shared_from_this();
50-
51-
auto &dbconfig = DBConfig::GetConfig(*db);
49+
auto &dbconfig = DBConfig::GetConfig(loader.GetDatabaseInstance());
5250
auto old_value = dbconfig.options.autoinstall_known_extensions;
5351
dbconfig.options.autoinstall_known_extensions = false;
5452
try {
@@ -69,12 +67,10 @@ INTERNAL_FUNC void QueryFarmSendTelemetry(ExtensionLoader &loader, const string
6967
auto result_obj = yyjson_mut_obj(doc);
7068
yyjson_mut_doc_set_root(doc, result_obj);
7169

72-
auto user_agent = "query-farm/20250915";
73-
auto platform = DuckDB::Platform();
7470
yyjson_mut_obj_add_str(doc, result_obj, "extension_name", extension_name.c_str());
7571
yyjson_mut_obj_add_str(doc, result_obj, "extension_version", extension_version.c_str());
76-
yyjson_mut_obj_add_str(doc, result_obj, "user_agent", user_agent);
77-
yyjson_mut_obj_add_str(doc, result_obj, "duckdb_platform", platform.c_str());
72+
yyjson_mut_obj_add_str(doc, result_obj, "user_agent", "query-farm/20250926");
73+
yyjson_mut_obj_add_str(doc, result_obj, "duckdb_platform", DuckDB::Platform().c_str());
7874
yyjson_mut_obj_add_str(doc, result_obj, "duckdb_library_version", DuckDB::LibraryVersion());
7975
yyjson_mut_obj_add_str(doc, result_obj, "duckdb_release_codename", DuckDB::ReleaseCodename());
8076
yyjson_mut_obj_add_str(doc, result_obj, "duckdb_source_id", DuckDB::SourceID());
@@ -89,8 +85,11 @@ INTERNAL_FUNC void QueryFarmSendTelemetry(ExtensionLoader &loader, const string
8985

9086
auto telemetry_string = string(telemetry_data, (size_t)telemetry_len);
9187

88+
yyjson_mut_doc_free(doc);
89+
free(telemetry_data);
90+
9291
// Send request asynchronously
93-
sendRequestAsync(db, telemetry_string);
92+
sendRequestAsync(loader.GetDatabaseInstance().shared_from_this(), telemetry_string);
9493
}
9594

9695
} // namespace duckdb

0 commit comments

Comments
 (0)