Change PVH Device Warning Behavior

[zellchristensen]

The problem you're addressing (if any)
When attaching a Device in the Devices tab of the Qube Settings, when the user clicks OK to save the settings, an error popup will appear if the Qube is set to PVH mode saying Devices cannot be attached in PVH mode, then the Settings window closes.

Describe the solution you'd like
Add the message to the top of the Device window (Similar to the message about devices and memory balancing) and grey out/make inaccessible the Available Devices section (such as when a Qube is running) when a Qube is set to PVH mode.

Where is the value to a user, and who might that user be?
Increases usability and clarity for the user.

Describe alternatives you've considered
Don't close the Settings window after the user clicks OK on the error popup so the user can correct the issue themselves by removing the devices.

OR

Have the error popup occur as soon as a device is added instead of waiting until the user clicks apply/ok.

OR

Have the error popup occur as soon as the Device tab is selected/opened (similar to the popup when opening Firewall Rules with networking disabled)

Additional context
Many people are desensitized to popup messages especially when only a single choice is given leading them to just click the choice without reading the prompt.
Currently, if a user fails to read the popup message, they may assume the settings are saved, then attempt to start the qube with the assumption that the devices they added were added when in fact they were not due to it being in PVH mode.
The user would have to repeat their steps and be mindful enough to re-read the popup, then open the settings again when the information could instead be more easily available to the user.

[andrewdavidwong]

Another idea is to say something like:

You assigned a device to this qube, which requires changing the virtualization mode to HVM. Would you like to change the virtualization mode to HVM? [Yes] [No]

If the user selects Yes, change it to HVM.

If the user selects No, execute the current behavior.

[marmarta]

But the disable-device-tab is how it works right now in Qubes 4.0? ( see commit QubesOS/qubes-manager@ebc7426 )
I tested a VM with PVH enabled before, and one in which I set virt mode to PVH, and both disabled devices and added a warning. I also can't set mode to PVH after adding devices.

What is the exact scenario, with setting, steps etc.?

[marmarta]

I found the situation! It's when default is selected and the default is PVH :) Will do a fix soon.

[zellchristensen]

@marmarta I just created a new Qube based on template, which defaults to PVH mode, then clicked the Devices tab, added devices, and clicked OK. I get the popup then the window closes.

[qubesos-bot]

Automated announcement from builder-github

The package qubes-manager-4.1.13-1.fc32 has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-manager_4.1.13-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-manager-4.1.13-1.fc32 has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-manager_4.1.13-1+deb9u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update