Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: QubesOS/qubes-gui-agent-linux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: QubesOS/qubes-gui-agent-linux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release4.2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 15 commits
  • 14 files changed
  • 3 contributors

Commits on Nov 8, 2024

  1. rpm: depend on cvt in F41+

    cvt tool is split out of xorg-x11-server-Xorg in Fedora 41+, add
    explicit dependency for it, as it's needed by qubes.SetMonitorLayout
    service.
    
    QubesOS/qubes-issues#9244
    
    (cherry picked from commit f5ac7a8)
    marmarek committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c737f93 View commit details
    Browse the repository at this point in the history
  2. version 4.2.19

    marmarek committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    18e56f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2024

  1. Move signal registraion earlier

    In case the service is stopped while Xorg is still starting up (and
    gui-agent still waits for the Xorg connectin in mkghandles), gui-agent
    would exit before killing Xorg and Xorg would try connecting back to the
    gui-agent forever, delaying the shutdown.
    
    Fix this by moving signal registration earlier, before Xorg startup.
    Since ghandles_for_vchan_reinitialize is now set before its fully
    initialized, initialize x_pid field explicitly and leave all the other
    fields zeroed (instead of random stack rubble).
    
    (cherry picked from commit 0806e2f)
    marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    0157424 View commit details
    Browse the repository at this point in the history
  2. Better handle premature Xorg exit

    Register proper signal handler for SIGCHLD, and collect the Xorg's
    zombie in it.
    
    This has two effects:
    1. The main loop can explicitly exit on Xorg termination, not only via
       receiving EOF on the socket.
    2. Due to not ignoring SIGCHLD anymore, accept() in mkghandles will also
       notice Xorg early exit and not wait indefinitely (it will fail with
       EINTR). For this case, improve error message.
    
    There is still a small race on startup, if Xorg exits before reaching
    accept() (or listen()) call. Handle this by checking just before
    accept() call. It isn't perfect (there is still a few instructions
    window where it wouldn't notice it in time), but it's good enough for
    practical purposes.
    
    QubesOS/qubes-issues#8060
    
    (cherry picked from commit eaba72a)
    marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    6fb0578 View commit details
    Browse the repository at this point in the history
  3. Fix logging in xf86-input-mfndev

    Use X's logging function instead of plain perror, to ensure the message
    is written in appropriate Xorg's log.
    
    (cherry picked from commit 1d2026a)
    marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    6d0540e View commit details
    Browse the repository at this point in the history
  4. pipewire: prevent starting in root session

    If root session is started early and pipewire gets started as part of
    it, it may connect to the audiovm earlier than the user's instance,
    effectively stealing the connection. Upstream already has
    ConditionUser=!root in relevant pulseaudio units, but not in pipewire
    ones. Add similar condition to pipewire.service unit.
    
    Fixes QubesOS/qubes-issues#9619
    
    (cherry picked from commit 7be8161)
    marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    b201b73 View commit details
    Browse the repository at this point in the history
  5. xf86-input-mfndev: interrupt attempts to contact gui-agent on SIGTERM

    If Xorg is going to be terminated, do not try to connect to gui-agent
    anymore. This avoids infinite loop when handling SIGTERM, and properly
    shutdown instead.
    
    (cherry picked from commit 0ad1350)
    marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    1993b85 View commit details
    Browse the repository at this point in the history
  6. Also set software rendering via the new $GDK_DISABLE variable

    GTK 4.14.6+ (Fedora 41+) has moved 'GDK_DEBUG=foo-disable' to
    'GDK_DISABLE=foo':
    
    https://gitlab.gnome.org/GNOME/gtk/-/commit/cde094a0dfde3024fae18e0c0d36e7cf5f795dc6
    
    New GTK versions print warnings for the old options:
    
        Unrecognized value "gl-disable". Try GDK_DEBUG=help
        Unrecognized value "vulkan-disable". Try GDK_DEBUG=help
    
    (cherry picked from commit dcf6256)
    rustybird authored and marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    0a1507f View commit details
    Browse the repository at this point in the history
  7. archlinux: update pulseaudio dependency

    Allow installing with newer pulseaudio in Arch. It uses a git snapshot,
    but it was verified there is no API change.
    
    Fixes QubesOS/qubes-issues#9660
    
    (cherry picked from commit fa222f4)
    marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    911a58d View commit details
    Browse the repository at this point in the history
  8. version 4.2.20

    marmarek committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    9de4a55 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2025

  1. xf86-video-dummy: fix type of CreateWindow field

    The function takes an argument. Actual function used there was okay, but
    the field in the structure used wrong type. And GCC 15 (rightfully)
    started complaining.
    Use CreateWindowProcPtr type to avoid similar issue in the future.
    
    QubesOS/qubes-issues#9807
    
    (cherry picked from commit a3f7636)
    marmarek committed Jun 6, 2025
    Configuration menu
    Copy the full SHA
    013d9d8 View commit details
    Browse the repository at this point in the history
  2. Format commands .qubesbuilder in single quotes

    When formatted in double quotes, the @SOURCE_DIR@ may be problematic
    with windows builder, as it will contain backslashes, and that will be
    misinterpreted by the yaml parser. While the windows paths are not
    relevant for those commands, .qubesbuilder file need to render correctly
    in that case too.
    
    (cherry picked from commit 5a50544)
    marmarek committed Jun 6, 2025
    Configuration menu
    Copy the full SHA
    feafe24 View commit details
    Browse the repository at this point in the history
  3. updated broken gui docs link

    (cherry picked from commit ca77a6e)
    degletnour authored and marmarek committed Jun 6, 2025
    Configuration menu
    Copy the full SHA
    4c78678 View commit details
    Browse the repository at this point in the history
  4. Add error checking on input device init

    (cherry picked from commit 6898bf9)
    marmarek committed Jun 6, 2025
    Configuration menu
    Copy the full SHA
    4429f07 View commit details
    Browse the repository at this point in the history
  5. version 4.2.21

    marmarek committed Jun 6, 2025
    Configuration menu
    Copy the full SHA
    e081fa3 View commit details
    Browse the repository at this point in the history
Loading