Skip to content

Commit d60d4bf

Browse files
committed
Add detailed template and hardware data to spec
Also add a common prefix so files for different templates are sorted together on OpenQA. For: QubesOS/qubes-issues#1512
1 parent 974b1af commit d60d4bf

File tree

1 file changed

+44
-39
lines changed

1 file changed

+44
-39
lines changed

tests/dispvm_perf_reader.py

Lines changed: 44 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ def end(self, plot, name: str = "", skip_fname: bool = False) -> None:
372372
else:
373373
if not skip_fname:
374374
name = get_fname()
375-
name = self.default_template + "_" + name
375+
name = "dispvm_perf-" + self.default_template + "_" + name
376376

377377
if self.output_dir:
378378
logging.info("Saving figure %s", name)
@@ -555,48 +555,53 @@ def graph_00_specs(self) -> None:
555555
"""System specifications graph."""
556556
first_test = list(self.data.keys())[0]
557557
data = self.data[first_test]
558-
specs = {
559-
"date": data["date"],
560-
"template-buildtime": data["template-buildtime"],
561-
"kernel": data["kernel"],
562-
"hcl-memory": data["hcl-memory"],
563-
"hcl-certified": data["hcl-certified"],
564-
"hcl-qubes": data["hcl-qubes"],
565-
"hcl-xen": data["hcl-xen"],
566-
"hcl-model": data["hcl-model"],
567-
"hcl-bios": data["hcl-bios"],
568-
"hcl-cpu": data["hcl-cpu"],
569-
"hcl-scsi": data.get("hcl-scsi", None),
570-
"hcl-nvme": data.get("hcl-nvme", None),
571-
}
572558
specs_text = """
573559
System specifications:
574560
575-
- Date: {}
576-
- Template: {}
577-
- Template build time: {}
578-
- Certified: {}
579-
- Qubes: {}
580-
- Kernel: {}
581-
- Xen: {}
582-
- RAM: {} MiB
583-
- CPU: {}
584-
- BIOS: {}
585-
- SCSI: {}
586-
- NVMe: {}
561+
- Global:
562+
- Date: {date}
563+
- Qubes: {hcl_qubes}
564+
- Xen: {hcl_xen}
565+
- Global Kernel: {hcl_kernel}
566+
- Template:
567+
- Name: {template}
568+
- Build time: {template_buildtime}
569+
- Last update: {template_last_update}
570+
- Virtual CPUs: {vcpus}
571+
- Bootstrap memory: {memory}
572+
- Maximum memory: {maxmem}
573+
- Kernel: {kernel}
574+
- Kernel options: {kernelopts}
575+
- Hardware:
576+
- Certified: {hcl_certified}
577+
- Brand: {hcl_brand}
578+
- Model: {hcl_model}
579+
- CPU: {hcl_cpu}
580+
- RAM: {hcl_memory} MiB
581+
- BIOS: {hcl_bios}
582+
- SCSI: {hcl_scsi}
583+
- NVMe: {hcl_nvme}
587584
""".format(
588-
specs["date"],
589-
self.default_template,
590-
specs["template-buildtime"],
591-
specs["hcl-certified"],
592-
specs["hcl-qubes"],
593-
specs["kernel"],
594-
specs["hcl-xen"],
595-
specs["hcl-memory"],
596-
specs["hcl-cpu"],
597-
specs["hcl-bios"],
598-
specs["hcl-scsi"],
599-
specs["hcl-nvme"],
585+
date=data["date"],
586+
template=self.default_template,
587+
template_buildtime=data["template-buildtime"],
588+
template_last_update=data["last-update"] or None,
589+
memory=data["memory"],
590+
maxmem=data["maxmem"],
591+
vcpus=data["vcpus"],
592+
kernel=data["kernel"],
593+
kernelopts=data["kernelopts"],
594+
hcl_memory=data["hcl-memory"],
595+
hcl_certified=data.get("hcl-certified"),
596+
hcl_qubes=data["hcl-qubes"],
597+
hcl_xen=data["hcl-xen"],
598+
hcl_kernel=data["hcl-kernel"],
599+
hcl_brand=data.get("hcl-brand"),
600+
hcl_model=data.get("hcl-model"),
601+
hcl_bios=data.get("hcl-bios"),
602+
hcl_cpu=data.get("hcl-cpu"),
603+
hcl_scsi=data.get("hcl-scsi"),
604+
hcl_nvme=data.get("hcl-nvme"),
600605
)
601606
fig = plt.figure(figsize=(2 * WIDTH, 2 * HEIGHT))
602607
fig.clf()

0 commit comments

Comments
 (0)