From 1cc84971e6d9fd31dec7e664165b1384b13bf2e2 Mon Sep 17 00:00:00 2001 From: Rusty Bird Date: Mon, 31 Jan 2022 11:01:01 +0000 Subject: [PATCH] storage/reflink: volume usage(): omit wrong docstring It's neither correct to say that this is "volume disk usage from the VM's perspective" (because an image file can be sparsified on the host, e.g. by restoring a backup, cloning a VM, or 'fallocate --dig-holes') nor that disk usage is "usually much lower from the host's perspective" (because it's not unusual for a volume to have multiple image files with lots of diverging data, e.g. revisions). Hard to say anything there that's true, helpful, and not a novella. --- qubes/storage/reflink.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/qubes/storage/reflink.py b/qubes/storage/reflink.py index 3152dedaf..c3b7953e1 100644 --- a/qubes/storage/reflink.py +++ b/qubes/storage/reflink.py @@ -348,9 +348,6 @@ def size(self): @property def usage(self): - ''' Return volume disk usage from the VM's perspective. It is - usually much lower from the host's perspective due to CoW. - ''' for path in (self._path_dirty, self._path_clean): with suppress(FileNotFoundError): return os.stat(path).st_blocks * 512