Skip to content

Commit c76a48c

Browse files
committed
Merge remote-tracking branch 'origin/pr/359' into pr-359-merge
* origin/pr/359: Late GUID for preloaded disposables Black formatter Handle preloaded disposables Black
2 parents 933256a + 1cf336d commit c76a48c

File tree

3 files changed

+463
-291
lines changed

3 files changed

+463
-291
lines changed

doc/manpages/qvm-features.rst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -455,12 +455,6 @@ disposable in the list. As soon as the preloaded disposable is requested to be
455455
used, it is removed from the `preload-dispvm` list, GUI applications entries
456456
become visible, followed by a new disposable being preloaded.
457457

458-
.. warning::
459-
460-
Applications configured to autostart by the disposable template or the
461-
template itself will be interactive before the preloaded disposable can be
462-
paused.
463-
464458
|
465459
| **Managed by**: system
466460
| **Valid on**: disposable template

qubesadmin/tests/tools/qvm_start_daemon.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,9 @@ def test_020_start_gui_for_vm(self, proc_mock):
231231
self.app.expected_calls[
232232
('test-vm', 'admin.vm.property.Get', 'virt_mode', None)] = \
233233
b'0\x00default=False type=str pv'
234+
self.app.expected_calls[
235+
('test-vm', 'admin.vm.property.Get', 'is_preload', None)] = \
236+
b"2QubesNoSuchPropertyErrorInvalid property 'is_preload' of test-vm"
234237
self.app.expected_calls[
235238
('test-vm', 'admin.vm.feature.CheckWithTemplate',
236239
'no-monitor-layout', None)] = \
@@ -272,6 +275,9 @@ def test_021_start_gui_for_vm_hvm(self, proc_mock):
272275
self.app.expected_calls[
273276
('test-vm', 'admin.vm.property.Get', 'debug', None)] = \
274277
b'0\x00default=False type=bool False'
278+
self.app.expected_calls[
279+
('test-vm', 'admin.vm.property.Get', 'is_preload', None)] = \
280+
b"2QubesNoSuchPropertyErrorInvalid property 'is_preload' of test-vm"
275281
self.app.expected_calls[
276282
('test-vm', 'admin.vm.feature.CheckWithTemplate',
277283
'no-monitor-layout', None)] = \
@@ -312,6 +318,9 @@ def test_022_start_gui_for_vm_hvm_stubdom(self):
312318
self.app.expected_calls[
313319
('test-vm', 'admin.vm.property.Get', 'debug', None)] = \
314320
b'0\x00default=False type=bool False'
321+
self.app.expected_calls[
322+
('test-vm', 'admin.vm.property.Get', 'is_preload', None)] = \
323+
b"2QubesNoSuchPropertyErrorInvalid property 'is_preload' of test-vm"
315324
self.app.expected_calls[
316325
('test-vm', 'admin.vm.feature.CheckWithTemplate',
317326
'no-monitor-layout', None)] = \
@@ -360,6 +369,9 @@ def test_030_start_gui_for_stubdomain(self):
360369
self.app.expected_calls[
361370
('test-vm', 'admin.vm.property.Get', 'stubdom_xid', None)] = \
362371
b'0\x00default=False type=int 3001'
372+
self.app.expected_calls[
373+
('test-vm', 'admin.vm.property.Get', 'is_preload', None)] = \
374+
b"2QubesNoSuchPropertyErrorInvalid property 'is_preload' of test-vm"
363375
self.app.expected_calls[
364376
('test-vm', 'admin.vm.feature.CheckWithTemplate', 'gui', None)] = \
365377
b'2\x00QubesFeatureNotFoundError\x00\x00Feature not set\x00'
@@ -391,6 +403,9 @@ def test_031_start_gui_for_stubdomain_forced(self):
391403
self.app.expected_calls[
392404
('test-vm', 'admin.vm.property.Get', 'stubdom_xid', None)] = \
393405
b'0\x00default=False type=int 3001'
406+
self.app.expected_calls[
407+
('test-vm', 'admin.vm.property.Get', 'is_preload', None)] = \
408+
b"2QubesNoSuchPropertyErrorInvalid property 'is_preload' of test-vm"
394409
# self.app.expected_calls[
395410
# ('test-vm', 'admin.vm.feature.CheckWithTemplate', 'gui', None)] = \
396411
# b'0\x00'
@@ -442,6 +457,9 @@ def test_040_start_gui(self):
442457
self.app.expected_calls[
443458
('test-vm', 'admin.vm.property.Get', 'guivm', None)] = \
444459
b'0\x00default=False type=vm gui-vm'
460+
self.app.expected_calls[
461+
('test-vm', 'admin.vm.property.Get', 'is_preload', None)] = \
462+
b"2QubesNoSuchPropertyErrorInvalid property 'is_preload' of test-vm"
445463

446464
# pylint: disable=protected-access
447465
self.app._local_name = 'gui-vm'

0 commit comments

Comments
 (0)