Optimise bin selection in difficulty calculation #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing Force! Full Album now takes 10s than 2 minutes.
This line is very inefficient.$O(n)$ instead of $O(n^2)$ , where n is
My PR optimises it so that
CalculateOverallDifficulty()
is nowStrainSolverData.Count
.The following patch lets you better check if there's any bug with this change.
Debug_Diffcalc_bin_optimization.patch
I wrote a verification tool:
https://github.com/WilliamQiufeng/Quaver.VerifyOptimizedBinDiffCalc
The optimization will for now only apply to 4K maps due to a bug described in #181