Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document jupyter notebook status and how to install a jupyter kernel #105

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

ngoldbaum
Copy link
Collaborator

No description provided.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngoldbaum! This does seem useful. The content looks reasonable to me, but I haven't tried this at all yet and am not sure what (if anything) is happening regarding free-threading in Jupyter land. @minrk since you were working on pyzmq free-threading support, I suspect you may be able to tell us more here. Does this look fine to you to add?

docs/installing_cpython.md Outdated Show resolved Hide resolved
## Installing a Jupyter Kernel

While jupyter [does not currently support free-threaded
Python](https://github.com/jupyter/notebook/issues/7512), you can use Jupyter
Copy link
Member

@rgommers rgommers Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're linking to issues, maybe Jupyter Lab needs one too? jupyterlab/jupyterlab#16850 is closest.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think the jupyterlab one is a better canonical issue. We'll probably close the one on jupyter/notebook as a duplicate.

@rgommers rgommers added the documentation Improvements or additions to documentation label Nov 4, 2024
@minrk
Copy link

minrk commented Nov 5, 2024

Yeah, I think this is fine. FWIW, I don't expect to need any patches in Jupyter. I added some detail to the linked issue that we are mostly just waiting on dependencies, and an example of how I was able to make a free-threading env with JupyterLab.

@ngoldbaum
Copy link
Collaborator Author

Thanks for the extra detail! I'm actively working on Shipping PyO3 0.23 so hopefully after that I can help with unblocking Jupyter's dependencies.

@ngoldbaum ngoldbaum merged commit eea337e into Quansight-Labs:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants