Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize task type in JSON #354

Closed
Roger-luo opened this issue Aug 1, 2023 · 2 comments · Fixed by #364
Closed

serialize task type in JSON #354

Roger-luo opened this issue Aug 1, 2023 · 2 comments · Fixed by #364
Assignees
Labels

Comments

@Roger-luo
Copy link
Member

No description provided.

@jon-wurtz
Copy link

jon-wurtz commented Aug 1, 2023

John Long 4:37 says:

So the job that goes to braket directly is a HardwareBatchTask, the job that goes to the local emulator is a BraketEmulatorBatchTask and for results if you submitted to the local emulator its BraketEmulatorBatchResult while from braket itself its a HardwareBatchResult
.
They should all be importable via from bloqade.task import … and you can load the jsons to crate objects via class_of_interest.load_json() because they all have a standard JSON interface
bloqade.task.braket_simulator.BraketEmulatorBatchTask
bloqade.task.hardware.HardwareBatchTask
bloqade.task.braket_simulator.BraketEmulatorBatchResult
bloqade.task.hardware.HardwareBatchResult

----------------------------------------- ME SAYS:
This is not sustainable. There should just be a bloqade.from_json( * ) function

@Roger-luo
Copy link
Member Author

yes, I agree with you on this @jon-wurtz this is because the program object is not serialized but only the emitted IR gets serialized. Hopefully this gets addressed together with task refactoring

@weinbe58 weinbe58 self-assigned this Aug 11, 2023
@weinbe58 weinbe58 added this to the internal-beta-1 milestone Aug 11, 2023
@weinbe58 weinbe58 linked a pull request Aug 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants