Implement evaluateDerivRatios in J1 and J2 #3785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement J1 and J2. JeeI will be next.
Remove unnecessary get_neighbours in DT.
Running on diamondC_1x1x1
"use_nonlocalpp_deriv" is cheap to run now.
From "gradient_test"
develop branch
this PR
use_nonlocalpp_deriv significantly reduces the difference between Numeric and Analytic.
New code path is much faster.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist