-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spin-orbit documentation #2733
Spin-orbit documentation #2733
Conversation
Can one of the admins verify this patch? |
Ok to test. |
No need to block this PR but after reading the documentation, I feel the current way is error-prone and need to simplify the input.
|
.
I agree that making some simplifications in the input specification is probably needed in the future. Moving the information into particleset seems reasonable, as we can just activate the appropriate builders in the code if the flag is present in particleset as opposed to reading it in multiple places from the xml input. The only thing I would like to keep in the Hamiltonian is the physicalSO flag, because there are some use cases where we would want to accumulate the spin-orbit as an observable but not have it in the local energy (like the perturbative/downfolding approach of Wagner). I think that particular parameter is more appropriate in the hamiltonian input. |
@rcclay approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
This PR adds some of the needed documentation in order to carry out spin-orbit calculations in QMCPACK for VMC/DMC. I added information in each of the relevant sections (Hamiltonian and Observables, Quantum Monte Carlo methods, etc) as well as a dedicated Spin-Orbit calculations in QMC section. I documented each of the relevant changes in the qmcpack input files in order to carry out one of these calculations, as well as provide some of the theory since this is likely unfamiliar to many users.
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
macbook
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.