Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting smooths (package "itsadug") #15

Open
dschoenig opened this issue Mar 5, 2021 · 0 comments
Open

Plotting smooths (package "itsadug") #15

dschoenig opened this issue Mar 5, 2021 · 0 comments

Comments

@dschoenig
Copy link
Collaborator

dschoenig commented Mar 5, 2021

Currently, the sections on other distribution and mixed effects rely heavily on itsadug::plot_smooth(), with the idea to plot smooth terms at the response scale.

I understand that this intends to make life easier for the participants of the workshop, but it actually has several problematic aspects:

  • In the common case that other continuous covariates are present, their value has to be fixed, and this is not discussed in the presentation.
  • Whoever works with generalized models and / or mixed models should be comfortable interpreting the effects on the link rather than the response scale. I think we should help participants work on that skill instead of avoiding it.
  • If plots at the response scale are needed, these can be easily produced with the combination of predict() and plot(), which appears to be the standard workflow in these cases. This also works for random effects, as these can be excluded from predictions.

In short, I think the current implementation may cause more problems (for the participants) down the line than it solves.

This could be addressed when working on #14 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant