Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull_request_template.md #155

Closed
manasb15 opened this issue Jul 12, 2021 · 4 comments · Fixed by #156
Closed

Update pull_request_template.md #155

manasb15 opened this issue Jul 12, 2021 · 4 comments · Fixed by #156
Assignees
@manasb15
Labels
DCP21 This issue will be considered for DCP 21 good first issue This issue is good for first timers 🟪 Level0 This issue will be considered as level 0 issue for LGM-SOC 21.Points will be 5

Comments

@manasb15
Copy link
Contributor

This point in the checklist :

(I have added my name in the contributors list at the end of README.md file.)

is obsolete. So it is wise to remove it.

@QAZIMAAZARSHAD please assign this to me under DCP21
@QAZIMAAZARSHAD QAZIMAAZARSHAD added DCP21 This issue will be considered for DCP 21 good first issue This issue is good for first timers 🟪 Level0 This issue will be considered as level 0 issue for LGM-SOC 21.Points will be 5 labels Jul 12, 2021
@QAZIMAAZARSHAD
Copy link
Owner

Yesterday you said it helps you in remembering git commands.

I want to tell, you can do these changes without using git quickly.
Just open the pull request template file in your repo, remove the line, commit changes, make PR. And its done.

@manasb15
Copy link
Contributor Author

@QAZIMAAZARSHAD Yes I know that method as well but I heard that it was like a shortcut or bad practice.

@QAZIMAAZARSHAD
Copy link
Owner

@QAZIMAAZARSHAD Yes I know that method as well but I heard that it was like a shortcut or bad practice.

Yaa in the case of many changes it causes difficulty in merging and few other problems like unnecessary indentations etc.

@manasb15
Copy link
Contributor Author

@QAZIMAAZARSHAD Ok then i will update it online for these small changes

@manasb15 manasb15 mentioned this issue Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manasb15 manasb15

Labels
DCP21 This issue will be considered for DCP 21 good first issue This issue is good for first timers 🟪 Level0 This issue will be considered as level 0 issue for LGM-SOC 21.Points will be 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pull_request_template.md manasb15/Income-Tax-Calculator
2 participants
@QAZIMAAZARSHAD @manasb15