Prevent REST's TranslatableModelMixin from creating instances without translation. Fixes KristianOellegaard#322.

Author: spectras

docs/public/release_notes.rst

@@ -58,6 +58,10 @@ Fixes:
 - Attempting to use a reserved name for a translated field now raises an
   :exc:`~django.core.exceptions.ImproperlyConfigured` exception instead of silently
   ignoring the field.
+- Instances created by serializers using
+  :class:`~hvad.contrib.restframework.serializers.TranslatableModelMixin`
+  in normal, non-*enforcing* mode can no longer be created without a translation.
+  — :issue:`322`.
 
 *****************************
 1.7.0 - current release

hvad/contrib/restframework/serializers.py

@@ -238,6 +238,14 @@ def validate(self, data):
             data['language_code'] = self.language
         return data
 
+    def create(self, validated_data):
+        # Having a language_code key forces creation of a translation in default
+        # language, even if no translated field is provided.
+        # This ensures the serializer will not create untranslated instances.
+        if 'language_code' not in validated_data:
+            validated_data['language_code'] = None
+        return super(TranslatableModelMixin, self).create(validated_data)
+
     def update(self, instance, data):
         'Handle switching to correct translation before actual update'
         enforce = 'language_code' in data

hvad/test_utils/project/app/models.py

@@ -12,7 +12,7 @@
 class Normal(TranslatableModel):
     shared_field = models.CharField(max_length=255)
     translations = TranslatedFields(
-        translated_field = models.CharField(max_length=255)
+        translated_field = models.CharField(max_length=255, blank=True)
     )
 
     def __str__(self):

hvad/tests/contrib/restframework.py

@@ -154,6 +154,20 @@ def test_create_normal(self):
         self.assertIsNotNone(obj.pk)
         self.assertSavedObject(obj, 'en', **data)
 
+    def test_create_normal_no_language(self):
+        'Deserialize a new instance, without including any translated field'
+        data = {
+            'shared_field': 'shared',
+        }
+        serializer = AutoSerializer(data=data)
+        self.assertTrue(serializer.is_valid())
+
+        with translation.override('en'):
+            obj = serializer.save()
+        self.assertIsNotNone(obj.pk)
+        self.assertSavedObject(obj, 'en', **data)
+        self.assertEqual(obj.language_code, 'en')
+
     def test_create_enforce(self):
         'Deserialize a new instance, with language-enforcing mode'
         data = {