fix action tests

Author: ItayTheDar

nest/core/decorators/controller.py

@@ -156,7 +156,7 @@ def add_route_to_router(
     if guards:
         dependencies = route_kwargs.get("dependencies", [])
         for guard in guards:
-            dependencies.append(Depends(guard.as_dependency()))
+            dependencies.append(guard.as_dependency())
         route_kwargs["dependencies"] = dependencies
 
     router.add_api_route(**route_kwargs)

nest/core/decorators/guards.py

@@ -1,4 +1,4 @@
-from fastapi import Request, HTTPException, status, Security
+from fastapi import Request, HTTPException, status, Security, Depends
 from fastapi.security.base import SecurityBase
 from typing import Optional
 import inspect
@@ -266,11 +266,10 @@ def as_dependency(cls):
         **Internal Implementation Details:**
         
         - If no security_scheme: Creates a simple dependency that validates the request
-        - If security_scheme exists: Creates a dependency that uses FastAPI's Security()
-          to extract credentials and pass them to the guard
+        - If security_scheme exists: Creates a dependency with Security parameter for OpenAPI
           
         The returned dependency will:
-        - Appear in OpenAPI schema (if security_scheme is set)
+        - Appear in OpenAPI schema (if security_scheme is set)  
         - Extract credentials automatically (if security_scheme is set)
         - Execute guard logic and raise 403 on failure
         """
@@ -280,16 +279,20 @@ async def dependency(request: Request):
                 guard = cls()
                 await guard(request)
 
-            return dependency
+            return Depends(dependency)
 
-        # Security scheme configured - use FastAPI Security dependency
+        # Security scheme configured - create function with Security parameter
+        # This allows FastAPI to detect the security requirement for OpenAPI
         security_scheme = cls.security_scheme
 
-        async def dependency(request: Request, credentials=Security(security_scheme)):
+        async def security_dependency(
+            request: Request,
+            credentials=Security(security_scheme)
+        ):
             guard = cls()
             await guard(request, credentials)
 
-        return dependency
+        return Depends(security_dependency)
 
 
 def UseGuards(*guards):

tests/test_core/test_decorators/test_guard.py

@@ -23,6 +23,15 @@ def can_activate(self, request: Request, credentials) -> bool:
         return True
 
 
+class JWTGuard(BaseGuard):
+    security_scheme = HTTPBearer()
+    
+    def can_activate(self, request: Request, credentials=None) -> bool:
+        if credentials and credentials.scheme == "Bearer":
+            return self.validate_jwt(credentials.credentials)
+        return False
+
+
 @Controller("/guard")
 class GuardController:
     @Get("/")
@@ -44,6 +53,18 @@ def test_guard_added_to_route_dependencies():
     assert callable(deps[0].dependency)
 
 
+def _has_security_requirements(dependant):
+    """Recursively check if a dependant or its dependencies have security requirements."""
+    if dependant.security_requirements:
+        return True
+    
+    for dep in dependant.dependencies:
+        if _has_security_requirements(dep):
+            return True
+    
+    return False
+
+
 def test_openapi_security_requirement():
     @Controller("/bearer")
     class BearerController:
@@ -54,4 +75,7 @@ def root(self):
 
     router = BearerController.get_router()
     route = router.routes[0]
-    assert route.dependant.security_requirements
+    
+    # Check if security requirements exist anywhere in the dependency tree
+    assert _has_security_requirements(route.dependant), \
+        "Security requirements should be present in the dependency tree for OpenAPI integration"