fix: Add logging to unittests loader #381
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yammesicka - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| def register_test_class(file_path: str, test_class): | ||
| log.debug(f'Registering test class {test_class=}') |
There was a problem hiding this comment.
suggestion (code_refinement): Consider reintroducing type hints for parameters.
Type hints were removed from the register_test_class function parameters. Reintroducing them could enhance code readability and maintain consistency.
| if len(sys.argv) != 2: | ||
| if len(sys.argv) < 2: | ||
| print('python load_tests.py test-module-path') # noqa: T201 | ||
| exit(-1) |
There was a problem hiding this comment.
suggestion (code_refinement): Consider providing more informative error messages.
While exiting the program when the path doesn't exist is correct, providing a more informative error message or logging the error could improve user experience.
| if "-X" in sys.argv: | ||
| log.configure(handlers=[{"sink": sys.stdout, "level": "DEBUG"}]) |
There was a problem hiding this comment.
suggestion (code_refinement): Ensure debug mode activation is documented.
Introducing a debug mode via the '-X' command-line argument is useful. Ensure this feature is well-documented for users and developers.
No description provided.