Extension fixes #817
Merged
Extension fixes #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the docstring and changes method to match documented behavior
auto-merge was automatically disabled
January 19, 2022 02:48
Head branch was pushed to by a user without write access
Fix docstring
Dorukyum
approved these changes
Jan 21, 2022
Lulalaby
approved these changes
Jan 21, 2022
7 tasks
krittick
added a commit
that referenced
this pull request
Jan 22, 2022
Revert #817 due to high-severity prefix command errors introduced by its changes
VincentRPS
pushed a commit
to VincentRPS/pycord
that referenced
this pull request
Jan 22, 2022
VincentRPS
pushed a commit
to VincentRPS/pycord
that referenced
this pull request
Jan 22, 2022
This reverts commit a9f6bd5.
This was referenced Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issues with unloading extensions:
AttributeErrorwhen an extension was unloaded on discord.BotKeyErrorwhen an extension with a command was unloaded before the bot was readyAlso fixes some other small issue with the behavior of
remove_application_commandnot matching the docstring.Changes made could be considered breaking changes, however, I don't believe these attributes are used very often externally, or that they should.
Checklist
type: ignorecomments were used, a comment is also left explaining why