Skip to content

Update contribution guidelines #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2021
Merged

Update contribution guidelines #415

merged 2 commits into from
Nov 7, 2021

Conversation

@FrostByte266
Copy link
Contributor

Summary

Update contribution guidelines to require all # type: ignore comments to also have an accompanying comment explaining why type checking warnings are being supressed

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@FrostByte266 FrostByte266 requested review from a team, Dorukyum, Middledot and WhoIsConch and removed request for a team November 7, 2021 20:51
@FrostByte266
Copy link
Contributor Author

oops, forgot about local files from another branch 🤦

@BobDotCom
Copy link
Contributor

Going to bypass checks and merge this myself, checks are failing currently as CI is being worked on.

@BobDotCom BobDotCom merged commit 5bee7e3 into master Nov 7, 2021
@FrostByte266 FrostByte266 deleted the contrib-guidelines branch November 7, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dorukyum Dorukyum Awaiting requested review from Dorukyum Dorukyum was automatically assigned from Pycord-Development/library-maintainers

@WhoIsConch WhoIsConch Awaiting requested review from WhoIsConch WhoIsConch was automatically assigned from Pycord-Development/library-maintainers

@Middledot Middledot Awaiting requested review from Middledot Middledot was automatically assigned from Pycord-Development/library-maintainers

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@Lulalaby Lulalaby Awaiting requested review from Lulalaby Lulalaby is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrostByte266 @BobDotCom