-
-
Notifications
You must be signed in to change notification settings - Fork 482
feat: ✨ Allow for functools.partial and functions returning an awaitable as autocomplete
#2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+103
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Paillat <me@paillat.dev>
Signed-off-by: Paillat <paillat@pycord.dev>
Signed-off-by: Paillat <paillat@pycord.dev>
Signed-off-by: Lala Sabathil <lala@pycord.dev>
Lulalaby
previously approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api approval. please test
3 tasks
|
conflicts~ |
|
sowwy, needs testing anyways tho I think |
Signed-off-by: Paillat <paillat@pycord.dev>
Soheab
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested.
Lulalaby
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows usage of functions with any number of optional parameters as autocomplete. This allows by extent the usage of partials and similar as autocomplete.
Fixes #2668
Superseeds #2669
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.