Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: subscriptions & related changes #2564

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

feat: subscriptions & related changes #2564

wants to merge 28 commits into from

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Aug 28, 2024 •
edited
Loading

Summary

https://discord.com/developers/docs/change-log#premium-apps-entitlement-migration-and-new-subscription-api

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 added bug Something isn't working documentation Improvements or additions to documentation priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Aug 28, 2024
@plun1331 plun1331 added this to the v2.7 milestone Aug 28, 2024
@plun1331 plun1331 self-assigned this Aug 28, 2024
@plun1331 plun1331 requested a review from a team as a code owner August 28, 2024 22:20
@plun1331
Copy link
Member Author

Untested (because i can't)

Lulalaby
Lulalaby reviewed Aug 28, 2024
View reviewed changes
discord/enums.py Outdated Show resolved Hide resolved
@Lulalaby
Update discord/enums.py
3ad15d6 
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
@Lulalaby
Copy link
Member

Lulalaby commented Aug 28, 2024 •
edited
Loading

@plun1331 if u want to test it lmk, i have a few apps with monitization ready u could use
tho these changes are being made in future, not sure if we should test it rn

plun1331 and others added 5 commits September 19, 2024 11:16
@plun1331
fix bugs
121268b
@plun1331
Merge branch 'master' into feat/subscriptions
e870a2e 
Signed-off-by: plun1331 <plun1331@gmail.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
74a96c8
@plun1331
Update CHANGELOG.md
e4aaaec 
Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331
Update iterators.py
b8a6bb7 
Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331
Copy link
Member Author

tested

@plun1331 plun1331 enabled auto-merge (squash) September 19, 2024 18:32
JustaSqu1d
JustaSqu1d suggested changes Sep 22, 2024
View reviewed changes
docs/api/enums.rst Outdated Show resolved Hide resolved
discord/monetization.py Outdated Show resolved Hide resolved
discord/iterators.py Outdated Show resolved Hide resolved
discord/iterators.py Outdated Show resolved Hide resolved
discord/iterators.py Outdated Show resolved Hide resolved
@plun1331
Copy link
Member Author

@Lulalaby review when available please :3

@Lulalaby
Copy link
Member

i'm still down with illness

@plun1331
Merge branch 'master' into feat/subscriptions
946b6bf 
Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331 plun1331 requested a review from Dorukyum October 2, 2024 18:10
@JustaSqu1d JustaSqu1d requested review from Lulalaby and removed request for Lulalaby October 25, 2024 18:09
@UnBonWhisky UnBonWhisky mentioned this pull request Oct 27, 2024
Closed
3 tasks
@plun1331
Merge branch 'master' into feat/subscriptions
f60cef1 
Signed-off-by: plun1331 <plun1331@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

At least 1 approving review is required to merge this pull request.

Assignees

@plun1331 plun1331

Labels
bug Something isn't working documentation Improvements or additions to documentation feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@plun1331 @Lulalaby @JustaSqu1d