Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Guild.query_members may accept empty query and limit #2419

Merged
merged 8 commits into from
Apr 16, 2024
Merged

fix: Guild.query_members may accept empty query and limit #2419

merged 8 commits into from
Apr 16, 2024

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Apr 11, 2024 •
edited
Loading

Summary

When requesting guild members through the gateway, you can pass an empty string query and limit=0 to recieve all members. This adjusts Guild.query_members to accept limit=None (or 0) to allow this behavior, though the default limit isn't changed to avoid breaking, and interprests query=None as an empty string.
As such, all guild members can be quickly recieved (and cached) through await guild.query_members(limit=None).

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner April 11, 2024 14:28
@pullapprove4 pullapprove4 bot requested a review from ChickenDevs April 11, 2024 14:28
plun1331
plun1331 requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please 👏 add 👏 a 👏 change 👏 log 👏 entry

@plun1331 plun1331 added status: awaiting review Awaiting review from a maintainer feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib changelog needed labels Apr 12, 2024
@plun1331 plun1331 added this to the v2.6 milestone Apr 12, 2024
JustaSqu1d
JustaSqu1d suggested changes Apr 12, 2024
View reviewed changes
discord/guild.py Outdated Show resolved Hide resolved
NeloBlivion and others added 3 commits April 12, 2024 21:39
@NeloBlivion @JustaSqu1d
grammar
ba26586 
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
@NeloBlivion
changelog
f43dab7
@NeloBlivion
Merge branch 'master' into query_adjust
e8ea2bf
@Lulalaby Lulalaby requested a review from plun1331 April 14, 2024 05:05
Lulalaby
Lulalaby previously approved these changes Apr 14, 2024
View reviewed changes
Dorukyum
Dorukyum previously requested changes Apr 15, 2024
View reviewed changes
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
NeloBlivion and others added 2 commits April 16, 2024 12:00
@NeloBlivion @Dorukyum
Update guild.py
078e8a8 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
@NeloBlivion @Dorukyum
Update guild.py
4f90195 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
@plun1331 plun1331 requested a review from Dorukyum April 16, 2024 17:38
@plun1331 plun1331 enabled auto-merge (squash) April 16, 2024 17:39
@Lulalaby Lulalaby disabled auto-merge April 16, 2024 20:00
@Lulalaby Lulalaby merged commit f5683c5 into Pycord-Development:master Apr 16, 2024
29 checks passed
plun1331 added a commit to SkyKings-Guild/pycord that referenced this pull request Apr 21, 2024
@plun1331 @NeloBlivion
@pre-commit-ci @Lulalaby @dependabot @jordan-day @Dorukyum @JustaSqu1d
j (#4)
51be093 
* feat: add once kwarg to Cog.listener (Pycord-Development#2403)

* add once kwarg to Cog.listener

* clarify

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>

* chore(pre-commit): pre-commit autoupdate (Pycord-Development#2410)

updates:
- [github.com/asottile/pyupgrade: v3.15.1 → v3.15.2](asottile/pyupgrade@v3.15.1...v3.15.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: pass proper state to interaction._guild (Pycord-Development#2411)

* fix: option and BridgeOption adjustments (Pycord-Development#2417)

* chore(pre-commit): pre-commit autoupdate (Pycord-Development#2416)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: implement Guild.search_members (Pycord-Development#2418)

* implement guild member search

* clarification.

* style(pre-commit): auto fixes from pre-commit.com hooks

* cl

* undo iteration

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* ci(deps): bump ribtoks/tdg-github-action from 0.4.7.pre.beta to 0.4.10.pre.beta (Pycord-Development#2420)

ci(deps): bump ribtoks/tdg-github-action

Bumps [ribtoks/tdg-github-action](https://github.com/ribtoks/tdg-github-action) from 0.4.7.pre.beta to 0.4.10.pre.beta.
- [Release notes](https://github.com/ribtoks/tdg-github-action/releases)
- [Commits](ribtoks/tdg-github-action@v0.4.7-beta...v0.4.10-beta)

---
updated-dependencies:
- dependency-name: ribtoks/tdg-github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>

* fix: Added member data to the raw_reaction_remove event (Pycord-Development#2412)

* fix: Added member data to the raw_reaction_remove event

* style(pre-commit): auto fixes from pre-commit.com hooks

* Added changelog.md for adding member data to raw reaction remove

* Update CHANGELOG.md

Signed-off-by: plun1331 <plun1331@gmail.com>

* doc: Updated documentation for the RawReactionActionEvent.member field

---------

Signed-off-by: plun1331 <plun1331@gmail.com>
Co-authored-by: root <root@DESKTOP-U7KGUE3>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>

* chore(pre-commit): pre-commit autoupdate (Pycord-Development#2422)

updates:
- [github.com/psf/black: 24.3.0 → 24.4.0](psf/black@24.3.0...24.4.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* docs: remove false optional (Pycord-Development#2424)

docs: not optional

* fix: Guild.query_members may accept empty query and limit (Pycord-Development#2419)

Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: plun1331 <plun1331@gmail.com>
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jordan-day <47164307+jordan-day@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-U7KGUE3>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

@plun1331 plun1331 plun1331 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees

@NeloBlivion NeloBlivion

Labels
API Reflection Discords API wasn't correctly reflected in the lib changelog needed feature Implements a feature status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.
5 participants
@NeloBlivion @Lulalaby @plun1331 @Dorukyum @JustaSqu1d